You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/12/23 14:47:09 UTC
[GitHub] [incubator-shardingsphere-doc] taojintianxia opened a new pull
request #400: Test engine fix
taojintianxia opened a new pull request #400: Test engine fix
URL: https://github.com/apache/incubator-shardingsphere-doc/pull/400
this PR should fix some spelling issue and remanagement the document.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu commented on a change in
pull request #400: Test engine fix
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #400: Test engine fix
URL: https://github.com/apache/incubator-shardingsphere-doc/pull/400#discussion_r361052887
##########
File path: document/current/content/features/test-engine/_index.cn.md
##########
@@ -7,6 +7,8 @@ chapter = true
ShardingSphere提供了完善的测试引擎。它以XML方式定义SQL，每条SQL由SQL解析单元测试引擎和整合测试引擎驱动，每个引擎分别为H2、MySQL、PostgreSQL、SQLServer和Oracle数据库运行测试用例。
+为了使测试更容易上手，shardingsphere 中的测试引擎不必修改任何 **Java** 代码，只需要修改相应的配置文件即可运行断言
Review comment:
Is there need a `.` to end of the sentence?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere-doc] taojintianxia commented on a change
in pull request #400: Test engine fix
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #400: Test engine fix
URL: https://github.com/apache/incubator-shardingsphere-doc/pull/400#discussion_r361137484
##########
File path: document/current/content/features/test-engine/_index.cn.md
##########
@@ -7,6 +7,8 @@ chapter = true
ShardingSphere提供了完善的测试引擎。它以XML方式定义SQL，每条SQL由SQL解析单元测试引擎和整合测试引擎驱动，每个引擎分别为H2、MySQL、PostgreSQL、SQLServer和Oracle数据库运行测试用例。
+为了使测试更容易上手，shardingsphere 中的测试引擎不必修改任何 **Java** 代码，只需要修改相应的配置文件即可运行断言
Review comment:
this should be a guideline : [中文文案排版](https://github.com/sparanoid/chinese-copywriting-guidelines)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #400:
Test engine fix
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #400: Test engine fix
URL: https://github.com/apache/incubator-shardingsphere-doc/pull/400
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere-doc] taojintianxia commented on a change
in pull request #400: Test engine fix
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #400: Test engine fix
URL: https://github.com/apache/incubator-shardingsphere-doc/pull/400#discussion_r361078485
##########
File path: document/current/content/features/test-engine/_index.cn.md
##########
@@ -7,6 +7,8 @@ chapter = true
ShardingSphere提供了完善的测试引擎。它以XML方式定义SQL，每条SQL由SQL解析单元测试引擎和整合测试引擎驱动，每个引擎分别为H2、MySQL、PostgreSQL、SQLServer和Oracle数据库运行测试用例。
+为了使测试更容易上手，shardingsphere 中的测试引擎不必修改任何 **Java** 代码，只需要修改相应的配置文件即可运行断言
Review comment:
so there shoud not be a full stop at the end of a sentence if the setence is the last one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu commented on a change in
pull request #400: Test engine fix
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #400: Test engine fix
URL: https://github.com/apache/incubator-shardingsphere-doc/pull/400#discussion_r361053005
##########
File path: document/current/content/features/test-engine/sql-case.cn.md
##########
@@ -5,15 +5,20 @@ title = "SQL测试用例"
weight = 1
+++
-## 配置
+## 目标
+
+SQL测试用例的代码位于 `sharding-sql-test` 模块下。该测试用例的作用主要有两个：
+
+ 1. 通过单元测试，测试通配符的替换以及 `SQLCasesLoader` 的稳定性
+ 2. 将SQL测试用例中 `resource` 下定义的所有 SQL 共享给其他项目
Review comment:
`resource` or `resources`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere-doc] taojintianxia commented on a change
in pull request #400: Test engine fix
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #400: Test engine fix
URL: https://github.com/apache/incubator-shardingsphere-doc/pull/400#discussion_r361137484
##########
File path: document/current/content/features/test-engine/_index.cn.md
##########
@@ -7,6 +7,8 @@ chapter = true
ShardingSphere提供了完善的测试引擎。它以XML方式定义SQL，每条SQL由SQL解析单元测试引擎和整合测试引擎驱动，每个引擎分别为H2、MySQL、PostgreSQL、SQLServer和Oracle数据库运行测试用例。
+为了使测试更容易上手，shardingsphere 中的测试引擎不必修改任何 **Java** 代码，只需要修改相应的配置文件即可运行断言
Review comment:
followings should be a guideline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services