[GitHub] [spark] cloud-fan commented on pull request #28026: [SPARK-31257][SQL] Unify create table syntax

[GitBox <gi...@apache.org>]

cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-707228025


   Hi @rdblue , I've already ported the parser change of this PR to our internal fork and tested it with real queries, do you mind if I create a PR for the parser change first? It can save your time to resolve code conflicts and you will still get the credits. Then you can continue your work of:
   1. Convert serde info to table properties for v2 create plans.
   2. Add an `option` namespace to distinguish SERDEPROPERTIES and OPTIONS in the table properties.
   3. Add the `EXTERNAL` table property to indicate CREATE EXTERNAL TABLE.
   
   It's also a good chance to split the work to follow the guideline. There are consensuses for these changes and I believe they can be merged soon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org