You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/12/19 20:30:00 UTC
[jira] [Commented] (AIRFLOW-1938) Remove tag version check in
setup.py
[ https://issues.apache.org/jira/browse/AIRFLOW-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297383#comment-16297383 ]
ASF subversion and git services commented on AIRFLOW-1938:
----------------------------------------------------------
Commit cc4404b5f75216680ee3a83d980511b5123d3ef3 in incubator-airflow's branch refs/heads/master from [~criccomini]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=cc4404b ]
[AIRFLOW-1938] Remove tag version check in setup.py
Closes #2889 from criccomini/AIRFLOW-1938
> Remove tag version check in setup.py
> ------------------------------------
>
> Key: AIRFLOW-1938
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1938
> Project: Apache Airflow
> Issue Type: Bug
> Reporter: Chris Riccomini
>
> This version check in setup.py is causing problems with releases:
> {noformat}
> tag = repo.git.describe(
> match='[0-9]*', exact_match=True,
> tags=True, dirty=True)
> assert tag == version, (tag, version)
> {noformat}
> The issue is that we need to tag a release as an RC, but we need to have the version of the RC be the final version. For example, tag=1.9.0rc1 and version=1.9.0. This assertion fails when we make an artifact like this.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)