[GitHub] [incubator-mxnet] mozga-intel commented on a change in pull request #20683: [master][bugfix] Remove exit 0 to avoid blocking in CI pipeline

[GitBox <gi...@apache.org>]

mozga-intel commented on a change in pull request #20683:
URL: https://github.com/apache/incubator-mxnet/pull/20683#discussion_r732903962



##########
File path: ci/docker/runtime_functions.sh
##########
@@ -740,19 +740,17 @@ sanity_clang() {
     GIT_DIFFERENCE=$(git diff)
     if [[ -z $GIT_DIFFERENCE ]]; then
         git remote remove "${GITHUB_RUN_ID}" # temporary remote is removed
-        exit 0
+    else
+        echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
+        echo "| Clang-format failures found! Run: "
+        echo "|    tools/lint/clang_format_ci.sh ${BASE_SHA} "
+        echo "| to fix this error. "
+        echo "| For more info, see: https://mxnet.apache.org/versions/master/community/clang_format_guide"
+        echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
+
+        echo "$GIT_DIFFERENCE"
+        git remote remove "${GITHUB_RUN_ID}" # temporary remote is removed

Review comment:
       At the end of a function, exit 0 is fine, I want to stop executing a script. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org