[GitHub] [dubbo] jojocodeX commented on a diff in pull request #12364: Metrics add sliding time window statistics

["jojocodeX (via GitHub)" <gi...@apache.org>]

jojocodeX commented on code in PR #12364:
URL: https://github.com/apache/dubbo/pull/12364#discussion_r1200528075


##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/model/key/MetricsKey.java:
##########
@@ -57,7 +57,9 @@ public enum MetricsKey {
     METRIC_RT_P95("dubbo.%s.rt.milliseconds.p95", "Response Time P95"),
     METRIC_RT_P90("dubbo.%s.rt.milliseconds.p90", "Response Time P90"),
     METRIC_RT_P50("dubbo.%s.rt.milliseconds.p50", "Response Time P50"),
-
+    METRIC_RT_INTERNAL_MIN("dubbo.%s.rt.interval.ms.min", "Response min Time Window"),
+    METRIC_RT_INTERNAL_MAX("dubbo.%s.rt.interval.ms.max", "Response max Time Window"),

Review Comment:
   已经调整



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org