You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Nick Heudecker (JIRA)" <ji...@apache.org> on 2007/05/31 22:11:15 UTC
[jira] Created: (WICKET-607) Stateless forms don't work with
QueryStringUrlCodingStrategy
Stateless forms don't work with QueryStringUrlCodingStrategy
------------------------------------------------------------
Key: WICKET-607
URL: https://issues.apache.org/jira/browse/WICKET-607
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.0-beta1
Environment: N/A
Reporter: Nick Heudecker
Trying to submit a stateless form to a page using QueryStringUrlCodingStrategy results in a NumberFormatException on the form's name:
java.lang.NumberFormatException: For input string: "myStatelessForm"
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
at java.lang.Integer.parseInt(Integer.java:447)
at java.lang.Integer.parseInt(Integer.java:497)
at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.addInterfaceParameters(WebRequestCodingStrategy.java:519)
at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.decode(WebRequestCodingStrategy.java:188)
at org.apache.wicket.Request.getRequestParameters(Request.java:179)
at org.apache.wicket.RequestCycle.step(RequestCycle.java:1049)
at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1135)
at org.apache.wicket.RequestCycle.request(RequestCycle.java:490)
at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248)
at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-607) Stateless forms don't work with
QueryStringUrlCodingStrategy
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501316 ]
Alastair Maw commented on WICKET-607:
-------------------------------------
Even if we fix this (put in an ugly catch block, for example), things still didn't work, due to QueryStringUrlCodingStrategy not knowing about BookmarkableListenerRequestTargets (see the special-case code in BookmarkablePageRequestTargetUrlCodingStrategy.decode() for example).
I fixed that in trunk in r544204, only I'm now not sure I've done the right thing - I think maybe we should be calling AbstractRequestCycleProcessor.resolveBookmarkablePage() instead, as that does much the same thing. Problem is, they're on different "layers" of the code, if you see what I mean.
Perhaps the code needs factoring out? Or maybe QueryStringUrlCodingStrategy needs to not extend BookmarkablePageRequestTargetUrlCodingStrategy? Or something else?
I'm not sure what's best to do here, and would appreciate some help from someone more familiar with the code.
> Stateless forms don't work with QueryStringUrlCodingStrategy
> ------------------------------------------------------------
>
> Key: WICKET-607
> URL: https://issues.apache.org/jira/browse/WICKET-607
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: N/A
> Reporter: Nick Heudecker
> Fix For: 1.3.0-rc1
>
>
> Trying to submit a stateless form to a page using QueryStringUrlCodingStrategy results in a NumberFormatException on the form's name:
> java.lang.NumberFormatException: For input string: "myStatelessForm"
> at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
> at java.lang.Integer.parseInt(Integer.java:447)
> at java.lang.Integer.parseInt(Integer.java:497)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.addInterfaceParameters(WebRequestCodingStrategy.java:519)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.decode(WebRequestCodingStrategy.java:188)
> at org.apache.wicket.Request.getRequestParameters(Request.java:179)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1049)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1135)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:490)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248)
> at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-607) Stateless forms don't work with
QueryStringUrlCodingStrategy
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-607:
--------------------------------
This is sufficiently complex that I'm not convinced it'll make it into beta2, sorry. Reallocating to rc1.
> Stateless forms don't work with QueryStringUrlCodingStrategy
> ------------------------------------------------------------
>
> Key: WICKET-607
> URL: https://issues.apache.org/jira/browse/WICKET-607
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: N/A
> Reporter: Nick Heudecker
> Fix For: 1.3.0-rc1
>
>
> Trying to submit a stateless form to a page using QueryStringUrlCodingStrategy results in a NumberFormatException on the form's name:
> java.lang.NumberFormatException: For input string: "myStatelessForm"
> at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
> at java.lang.Integer.parseInt(Integer.java:447)
> at java.lang.Integer.parseInt(Integer.java:497)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.addInterfaceParameters(WebRequestCodingStrategy.java:519)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.decode(WebRequestCodingStrategy.java:188)
> at org.apache.wicket.Request.getRequestParameters(Request.java:179)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1049)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1135)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:490)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248)
> at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-607) Stateless forms don't work with
QueryStringUrlCodingStrategy
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512540 ]
Eelco Hillenius commented on WICKET-607:
----------------------------------------
Maybe we should look at this at the same time: http://www.nabble.com/stateless-forms-don%27t-work-on-mounted-pages-tf4073295.html
> Stateless forms don't work with QueryStringUrlCodingStrategy
> ------------------------------------------------------------
>
> Key: WICKET-607
> URL: https://issues.apache.org/jira/browse/WICKET-607
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: N/A
> Reporter: Nick Heudecker
> Fix For: 1.3.0-rc1
>
>
> Trying to submit a stateless form to a page using QueryStringUrlCodingStrategy results in a NumberFormatException on the form's name:
> java.lang.NumberFormatException: For input string: "myStatelessForm"
> at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
> at java.lang.Integer.parseInt(Integer.java:447)
> at java.lang.Integer.parseInt(Integer.java:497)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.addInterfaceParameters(WebRequestCodingStrategy.java:519)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.decode(WebRequestCodingStrategy.java:188)
> at org.apache.wicket.Request.getRequestParameters(Request.java:179)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1049)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1135)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:490)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248)
> at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-607) Stateless forms don't work with
QueryStringUrlCodingStrategy
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501297 ]
Alastair Maw commented on WICKET-607:
-------------------------------------
Although the above /was/ an issue, it was fixed a while back. Unfortunately, stateless forms for QueryStringUrlCodingStrategy still do not work. :-(
The issue here is that WebRequestCycleProcessor is looking for a component path before it looks for mounts. And once it has found a component path, it's trying to resolve a rendered page for it. Of course, with stateless stuff, there is no rendered page available in the PageMap, so you get a PageExpiredException.
> Stateless forms don't work with QueryStringUrlCodingStrategy
> ------------------------------------------------------------
>
> Key: WICKET-607
> URL: https://issues.apache.org/jira/browse/WICKET-607
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: N/A
> Reporter: Nick Heudecker
> Assignee: Alastair Maw
> Fix For: 1.3.0-rc1
>
>
> Trying to submit a stateless form to a page using QueryStringUrlCodingStrategy results in a NumberFormatException on the form's name:
> java.lang.NumberFormatException: For input string: "myStatelessForm"
> at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
> at java.lang.Integer.parseInt(Integer.java:447)
> at java.lang.Integer.parseInt(Integer.java:497)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.addInterfaceParameters(WebRequestCodingStrategy.java:519)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.decode(WebRequestCodingStrategy.java:188)
> at org.apache.wicket.Request.getRequestParameters(Request.java:179)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1049)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1135)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:490)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248)
> at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-607) Stateless forms don't work with
QueryStringUrlCodingStrategy
Posted by "Nick Heudecker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500519 ]
Nick Heudecker commented on WICKET-607:
---------------------------------------
http://localhost:8080/home?wicket:interface=%3A0%3ApromoColumn%3ApromoCodePanel%3AmyStatelessForm%3A%3AIFormSubmitListener%3A
> Stateless forms don't work with QueryStringUrlCodingStrategy
> ------------------------------------------------------------
>
> Key: WICKET-607
> URL: https://issues.apache.org/jira/browse/WICKET-607
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: N/A
> Reporter: Nick Heudecker
> Assignee: Eelco Hillenius
>
> Trying to submit a stateless form to a page using QueryStringUrlCodingStrategy results in a NumberFormatException on the form's name:
> java.lang.NumberFormatException: For input string: "myStatelessForm"
> at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
> at java.lang.Integer.parseInt(Integer.java:447)
> at java.lang.Integer.parseInt(Integer.java:497)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.addInterfaceParameters(WebRequestCodingStrategy.java:519)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.decode(WebRequestCodingStrategy.java:188)
> at org.apache.wicket.Request.getRequestParameters(Request.java:179)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1049)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1135)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:490)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248)
> at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-607) Stateless forms don't work with
QueryStringUrlCodingStrategy
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius reassigned WICKET-607:
--------------------------------------
Assignee: Eelco Hillenius
> Stateless forms don't work with QueryStringUrlCodingStrategy
> ------------------------------------------------------------
>
> Key: WICKET-607
> URL: https://issues.apache.org/jira/browse/WICKET-607
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: N/A
> Reporter: Nick Heudecker
> Assignee: Eelco Hillenius
>
> Trying to submit a stateless form to a page using QueryStringUrlCodingStrategy results in a NumberFormatException on the form's name:
> java.lang.NumberFormatException: For input string: "myStatelessForm"
> at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
> at java.lang.Integer.parseInt(Integer.java:447)
> at java.lang.Integer.parseInt(Integer.java:497)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.addInterfaceParameters(WebRequestCodingStrategy.java:519)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.decode(WebRequestCodingStrategy.java:188)
> at org.apache.wicket.Request.getRequestParameters(Request.java:179)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1049)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1135)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:490)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248)
> at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-607) Stateless forms don't work with
QueryStringUrlCodingStrategy
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-607:
--------------------------------
Fix Version/s: (was: 1.3.0-beta2)
1.3.0-rc1
Assignee: (was: Alastair Maw)
> Stateless forms don't work with QueryStringUrlCodingStrategy
> ------------------------------------------------------------
>
> Key: WICKET-607
> URL: https://issues.apache.org/jira/browse/WICKET-607
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: N/A
> Reporter: Nick Heudecker
> Fix For: 1.3.0-rc1
>
>
> Trying to submit a stateless form to a page using QueryStringUrlCodingStrategy results in a NumberFormatException on the form's name:
> java.lang.NumberFormatException: For input string: "myStatelessForm"
> at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
> at java.lang.Integer.parseInt(Integer.java:447)
> at java.lang.Integer.parseInt(Integer.java:497)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.addInterfaceParameters(WebRequestCodingStrategy.java:519)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.decode(WebRequestCodingStrategy.java:188)
> at org.apache.wicket.Request.getRequestParameters(Request.java:179)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1049)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1135)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:490)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248)
> at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-607) Stateless forms don't work with
QueryStringUrlCodingStrategy
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-607:
--------------------------------
Fix Version/s: 1.3.0-beta2
> Stateless forms don't work with QueryStringUrlCodingStrategy
> ------------------------------------------------------------
>
> Key: WICKET-607
> URL: https://issues.apache.org/jira/browse/WICKET-607
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: N/A
> Reporter: Nick Heudecker
> Assignee: Alastair Maw
> Fix For: 1.3.0-beta2
>
>
> Trying to submit a stateless form to a page using QueryStringUrlCodingStrategy results in a NumberFormatException on the form's name:
> java.lang.NumberFormatException: For input string: "myStatelessForm"
> at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
> at java.lang.Integer.parseInt(Integer.java:447)
> at java.lang.Integer.parseInt(Integer.java:497)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.addInterfaceParameters(WebRequestCodingStrategy.java:519)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.decode(WebRequestCodingStrategy.java:188)
> at org.apache.wicket.Request.getRequestParameters(Request.java:179)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1049)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1135)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:490)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248)
> at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-607) Stateless forms don't work with
QueryStringUrlCodingStrategy
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500473 ]
Johan Compagner commented on WICKET-607:
----------------------------------------
do you have the request url that goes wrong? (so the form action url)
> Stateless forms don't work with QueryStringUrlCodingStrategy
> ------------------------------------------------------------
>
> Key: WICKET-607
> URL: https://issues.apache.org/jira/browse/WICKET-607
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: N/A
> Reporter: Nick Heudecker
> Assignee: Eelco Hillenius
>
> Trying to submit a stateless form to a page using QueryStringUrlCodingStrategy results in a NumberFormatException on the form's name:
> java.lang.NumberFormatException: For input string: "myStatelessForm"
> at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
> at java.lang.Integer.parseInt(Integer.java:447)
> at java.lang.Integer.parseInt(Integer.java:497)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.addInterfaceParameters(WebRequestCodingStrategy.java:519)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.decode(WebRequestCodingStrategy.java:188)
> at org.apache.wicket.Request.getRequestParameters(Request.java:179)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1049)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1135)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:490)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248)
> at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-607) Stateless forms don't work with
QueryStringUrlCodingStrategy
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner reassigned WICKET-607:
--------------------------------------
Assignee: Alastair Maw (was: Eelco Hillenius)
we seem to miss the last %3A == : == the dept param?
just another wicket url:
wicket:interface=:1:actionLink::ILinkListener::
2 :: after the listener interface
And dept is AlMaws baby!
> Stateless forms don't work with QueryStringUrlCodingStrategy
> ------------------------------------------------------------
>
> Key: WICKET-607
> URL: https://issues.apache.org/jira/browse/WICKET-607
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Environment: N/A
> Reporter: Nick Heudecker
> Assignee: Alastair Maw
>
> Trying to submit a stateless form to a page using QueryStringUrlCodingStrategy results in a NumberFormatException on the form's name:
> java.lang.NumberFormatException: For input string: "myStatelessForm"
> at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
> at java.lang.Integer.parseInt(Integer.java:447)
> at java.lang.Integer.parseInt(Integer.java:497)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.addInterfaceParameters(WebRequestCodingStrategy.java:519)
> at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.decode(WebRequestCodingStrategy.java:188)
> at org.apache.wicket.Request.getRequestParameters(Request.java:179)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1049)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1135)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:490)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248)
> at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.