You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by bschuchardt <gi...@git.apache.org> on 2017/08/28 21:51:36 UTC
[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...
GitHub user bschuchardt opened a pull request:
https://github.com/apache/geode/pull/746
GEODE-3529 move new client/server security classes to a different pac…
@kohlmu-pivotal @hiteshk25 @galen-pivotal @pivotal-amurmann @metatype
The new classes/interfaces have been moved to org.apache.geode.security.server.
A package.html is now provided that describes the purpose of the package.
The word "Stream" has been removed from the names of these classes. Those
names make sense in the context of the Protobuf support classes in
org.apache.geode.internal.cache.tier.sockets classes but not when taken
as a separate group of classes.
The method Authenticator.receiveMessage() has been renamed to
Authenticator.authenticate().
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/geode feature/GEODE-3529
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/746.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #746
----
commit ed3ac98cec1610bde2c1cbcad5a0ff542296ea2a
Author: Bruce Schuchardt <bs...@pivotal.io>
Date: 2017-08-28T21:43:45Z
GEODE-3529 move new client/server security classes to a different package
The new classes/interfaces have been moved to org.apache.geode.security.server.
A package.html is now provided that describes the purpose of the package.
The word "Stream" has been removed from the names of these classes. Those
names make sense in the context of the Protobuf support classes in
org.apache.geode.internal.cache.tier.sockets classes but not when taken
as a separate group of classes.
The method Authenticator.receiveMessage() has been renamed to
Authenticator.authenticate().
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #746: GEODE-3529 move new client/server security classes to a di...
Posted by bschuchardt <gi...@git.apache.org>.
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/746
Travis check failed in an unrelated unit test. This test passes on my branch when I run it individually or as part of the "build" task.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...
Posted by bschuchardt <gi...@git.apache.org>.
Github user bschuchardt closed the pull request at:
https://github.com/apache/geode/pull/746
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...
Posted by hiteshk25 <gi...@git.apache.org>.
Github user hiteshk25 commented on a diff in the pull request:
https://github.com/apache/geode/pull/746#discussion_r135870888
--- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java ---
@@ -41,8 +41,8 @@ private synchronized void initializeAuthenticatorsMap() {
return;
}
authenticators = new HashMap<>();
- ServiceLoader<StreamAuthenticator> loader = ServiceLoader.load(StreamAuthenticator.class);
- for (StreamAuthenticator streamAuthenticator : loader) {
+ ServiceLoader<Authenticator> loader = ServiceLoader.load(Authenticator.class);
+ for (Authenticator streamAuthenticator : loader) {
--- End diff --
may we want to remove stream from variable name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/746
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...
Posted by hiteshk25 <gi...@git.apache.org>.
Github user hiteshk25 commented on a diff in the pull request:
https://github.com/apache/geode/pull/746#discussion_r135871243
--- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java ---
@@ -57,15 +57,14 @@ private synchronized ClientProtocolMessageHandler initializeMessageHandler() {
return protocolHandler;
}
- private StreamAuthenticator findStreamAuthenticator(String implementationID) {
+ private Authenticator findStreamAuthenticator(String implementationID) {
--- End diff --
stream in method name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #746: GEODE-3529 move new client/server security classes to a di...
Posted by galen-pivotal <gi...@git.apache.org>.
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/746
@bschuchardt try closing and reopening; I think that will make Travis restart.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...
Posted by bschuchardt <gi...@git.apache.org>.
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/746#discussion_r135888279
--- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java ---
@@ -41,8 +41,8 @@ private synchronized void initializeAuthenticatorsMap() {
return;
}
authenticators = new HashMap<>();
- ServiceLoader<StreamAuthenticator> loader = ServiceLoader.load(StreamAuthenticator.class);
- for (StreamAuthenticator streamAuthenticator : loader) {
+ ServiceLoader<Authenticator> loader = ServiceLoader.load(Authenticator.class);
+ for (Authenticator streamAuthenticator : loader) {
--- End diff --
The "stream" concept is fine in the cache.tier.sockets package - there are other uses of it there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...
Posted by bschuchardt <gi...@git.apache.org>.
GitHub user bschuchardt reopened a pull request:
https://github.com/apache/geode/pull/746
GEODE-3529 move new client/server security classes to a different pac…
@kohlmu-pivotal @hiteshk25 @galen-pivotal @pivotal-amurmann @metatype
The new classes/interfaces have been moved to org.apache.geode.security.server.
A package.html is now provided that describes the purpose of the package.
The word "Stream" has been removed from the names of these classes. Those
names make sense in the context of the Protobuf support classes in
org.apache.geode.internal.cache.tier.sockets classes but not when taken
as a separate group of classes.
The method Authenticator.receiveMessage() has been renamed to
Authenticator.authenticate().
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/geode feature/GEODE-3529
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/746.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #746
----
commit ed3ac98cec1610bde2c1cbcad5a0ff542296ea2a
Author: Bruce Schuchardt <bs...@pivotal.io>
Date: 2017-08-28T21:43:45Z
GEODE-3529 move new client/server security classes to a different package
The new classes/interfaces have been moved to org.apache.geode.security.server.
A package.html is now provided that describes the purpose of the package.
The word "Stream" has been removed from the names of these classes. Those
names make sense in the context of the Protobuf support classes in
org.apache.geode.internal.cache.tier.sockets classes but not when taken
as a separate group of classes.
The method Authenticator.receiveMessage() has been renamed to
Authenticator.authenticate().
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #746: GEODE-3529 move new client/server security classes to a di...
Posted by bschuchardt <gi...@git.apache.org>.
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/746
okay - travis ci passed this time
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...
Posted by hiteshk25 <gi...@git.apache.org>.
Github user hiteshk25 commented on a diff in the pull request:
https://github.com/apache/geode/pull/746#discussion_r135871358
--- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java ---
@@ -57,15 +57,14 @@ private synchronized ClientProtocolMessageHandler initializeMessageHandler() {
return protocolHandler;
}
- private StreamAuthenticator findStreamAuthenticator(String implementationID) {
+ private Authenticator findStreamAuthenticator(String implementationID) {
if (authenticators == null) {
initializeAuthenticatorsMap();
}
- Class<? extends StreamAuthenticator> streamAuthenticatorClass =
- authenticators.get(implementationID);
+ Class<? extends Authenticator> streamAuthenticatorClass = authenticators.get(implementationID);
--- End diff --
stream in variable name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---