You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by gu...@apache.org on 2023/03/15 14:41:24 UTC
[flink] 02/02: [FLINK-31420][test] Fix unstable test ThreadInfoRequestCoordinatorTest#testShutDown.
This is an automated email from the ASF dual-hosted git repository.
guoweijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 7fccd5992f6222df62ed850542ef50b0714cd647
Author: Weijie Guo <re...@163.com>
AuthorDate: Mon Mar 13 23:09:08 2023 +0800
[FLINK-31420][test] Fix unstable test ThreadInfoRequestCoordinatorTest#testShutDown.
testShutDown using two gateways contains a timeout gateway but expected all request futures not done before shutdown. If the timeout reached, this future will be failed, result in request future to be done.
This closes #22171
---
.../webmonitor/threadinfo/ThreadInfoRequestCoordinatorTest.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/threadinfo/ThreadInfoRequestCoordinatorTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/threadinfo/ThreadInfoRequestCoordinatorTest.java
index f483de63822..2c9b1220b62 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/threadinfo/ThreadInfoRequestCoordinatorTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/threadinfo/ThreadInfoRequestCoordinatorTest.java
@@ -173,7 +173,9 @@ class ThreadInfoRequestCoordinatorTest {
Map<ImmutableSet<ExecutionAttemptID>, CompletableFuture<TaskExecutorThreadInfoGateway>>
executionWithGateways =
createMockSubtaskWithGateways(
- CompletionType.SUCCESSFULLY, CompletionType.TIMEOUT);
+ // request future will only be completed after all gateways
+ // successfully return thread infos.
+ CompletionType.SUCCESSFULLY, CompletionType.NEVER_COMPLETE);
List<CompletableFuture<VertexThreadInfoStats>> requestFutures = new ArrayList<>();