You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/07 04:11:21 UTC

Review Request: Fixed cgroup tests tear down to be more robust by using cgroups::destroy.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9790/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

We observed some flakiness in terms of cleaning up the cgroups within the hierarchy.


Diffs
-----

  src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2 

Diff: https://reviews.apache.org/r/9790/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request: Fixed cgroup tests tear down to be more robust by using cgroups::destroy.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9790/#review17552
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On March 7, 2013, 3:11 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9790/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 3:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> We observed some flakiness in terms of cleaning up the cgroups within the hierarchy.
> 
> 
> Diffs
> -----
> 
>   src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2 
> 
> Diff: https://reviews.apache.org/r/9790/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request: Fixed cgroup tests tear down to be more robust by using cgroups::destroy.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9790/#review17519
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On March 7, 2013, 3:11 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9790/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 3:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> We observed some flakiness in terms of cleaning up the cgroups within the hierarchy.
> 
> 
> Diffs
> -----
> 
>   src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2 
> 
> Diff: https://reviews.apache.org/r/9790/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>