You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/09 19:54:03 UTC
[GitHub] [superset] codecov-io commented on pull request #13021: refactor(native-filters): decouple params from filter config modal (first phase)
codecov-io commented on pull request #13021:
URL: https://github.com/apache/superset/pull/13021#issuecomment-776199988
# [Codecov](https://codecov.io/gh/apache/superset/pull/13021?src=pr&el=h1) Report
> Merging [#13021](https://codecov.io/gh/apache/superset/pull/13021?src=pr&el=desc) (ce0c3f9) into [master](https://codecov.io/gh/apache/superset/commit/c440d98fadaf5ee1859bd8c4a01036fb71f1753a?el=desc) (c440d98) will **increase** coverage by `8.68%`.
> The diff coverage is `33.33%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13021/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13021?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13021 +/- ##
==========================================
+ Coverage 53.17% 61.86% +8.68%
==========================================
Files 449 546 +97
Lines 14826 20152 +5326
Branches 3959 5268 +1309
==========================================
+ Hits 7884 12467 +4583
- Misses 6942 7471 +529
- Partials 0 214 +214
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.86% <33.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13021?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...components/nativeFilters/FilterBar/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/13021/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclZhbHVlLnRzeA==) | `23.07% <0.00%> (-60.65%)` | :arrow_down: |
| [...iveFilters/FilterConfigModal/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/13021/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.74% <ø> (-9.27%)` | :arrow_down: |
| [...omponents/nativeFilters/FilterConfigModal/state.ts](https://codecov.io/gh/apache/superset/pull/13021/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwvc3RhdGUudHM=) | `70.58% <0.00%> (+15.03%)` | :arrow_up: |
| [...omponents/nativeFilters/FilterConfigModal/types.ts](https://codecov.io/gh/apache/superset/pull/13021/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/13021/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/13021/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
| [...ntend/src/filters/components/Range/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13021/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9jb250cm9sUGFuZWwudHM=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13021/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tiveFilters/FilterConfigModal/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13021/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `64.70% <35.71%> (-12.66%)` | :arrow_down: |
| [...omponents/nativeFilters/FilterConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/13021/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwvdXRpbHMudHM=) | `90.24% <60.00%> (+65.60%)` | :arrow_up: |
| ... and [470 more](https://codecov.io/gh/apache/superset/pull/13021/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13021?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13021?src=pr&el=footer). Last update [c440d98...ce0c3f9](https://codecov.io/gh/apache/superset/pull/13021?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org