[GitHub] [netbeans] jlahoda commented on a change in pull request #2104: Fix ant property to exclude tests

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #2104:
URL: https://github.com/apache/netbeans/pull/2104#discussion_r414800239



##########
File path: nbbuild/templates/common.xml
##########
@@ -621,7 +621,6 @@
             <depend srcdir="${test.@{test.type}.src.dir}" destdir="${build.test.@{test.type}.classes.dir}" cache="${build.test.@{test.type}.dir}/depcache">
                 <classpath refid="test.@{test.type}.cp"/>
             </depend>
-            <property name="test.excludes" value=""/> <!-- # 113770 -->
             <nb-javac srcdir="${test.@{test.type}.src.dir}" destdir="${build.test.@{test.type}.classes.dir}" excludes="${test.excludes}"

Review comment:
       Basically, I guess I am suggesting this:
   ```suggestion
               <property name="test.javac.excludes" value=""/> <!-- # 113770 -->
               <nb-javac srcdir="${test.@{test.type}.src.dir}" destdir="${build.test.@{test.type}.classes.dir}" excludes="${test.javac.excludes}"
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists