You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/25 06:21:04 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #373: Suppress
some "'noreturn' function does return" warnings
yamt opened a new pull request #373: Suppress some "'noreturn' function does return" warnings
URL: https://github.com/apache/incubator-nuttx/pull/373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #373:
Suppress some "'noreturn' function does return" warnings
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #373: Suppress some "'noreturn' function does return" warnings
URL: https://github.com/apache/incubator-nuttx/pull/373#discussion_r383759595
##########
File path: tools/mksyscall.c
##########
@@ -228,6 +228,11 @@ static void generate_proxy(int nparms)
fprintf(stream, "/* Auto-generated %s proxy file -- do not edit */\n\n", g_parm[NAME_INDEX]);
fprintf(stream, "#include <nuttx/config.h>\n");
+ /* Suppress "'noreturn' function does return" warnings. */
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #373:
Suppress some "'noreturn' function does return" warnings
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #373: Suppress some "'noreturn' function does return" warnings
URL: https://github.com/apache/incubator-nuttx/pull/373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #373: Suppress some "'noreturn' function does return" warnings
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #373: Suppress some "'noreturn' function does return" warnings
URL: https://github.com/apache/incubator-nuttx/pull/373#discussion_r383727659
##########
File path: arch/arm/src/common/up_pthread_start.c
##########
@@ -80,6 +80,8 @@ void up_pthread_start(pthread_startroutine_t entrypt, pthread_addr_t arg)
/* Let sys_call2() do all of the work */
sys_call2(SYS_pthread_start, (uintptr_t)entrypt, (uintptr_t)arg);
+
+ PANIC();
Review comment:
If so, we need to change all location to ensure the warning get clear for all arch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #373: Suppress some "'noreturn' function does return" warnings
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #373: Suppress some "'noreturn' function does return" warnings
URL: https://github.com/apache/incubator-nuttx/pull/373#discussion_r383727659
##########
File path: arch/arm/src/common/up_pthread_start.c
##########
@@ -80,6 +80,8 @@ void up_pthread_start(pthread_startroutine_t entrypt, pthread_addr_t arg)
/* Let sys_call2() do all of the work */
sys_call2(SYS_pthread_start, (uintptr_t)entrypt, (uintptr_t)arg);
+
+ PANIC();
Review comment:
If so, we need to change all location to ensure the warning get clear for all arch or remove noreturn_function from the function declaration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #373:
Suppress some "'noreturn' function does return" warnings
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #373: Suppress some "'noreturn' function does return" warnings
URL: https://github.com/apache/incubator-nuttx/pull/373#discussion_r383759674
##########
File path: arch/arm/src/common/up_pthread_start.c
##########
@@ -80,6 +80,8 @@ void up_pthread_start(pthread_startroutine_t entrypt, pthread_addr_t arg)
/* Let sys_call2() do all of the work */
sys_call2(SYS_pthread_start, (uintptr_t)entrypt, (uintptr_t)arg);
+
+ PANIC();
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #373:
Suppress some "'noreturn' function does return" warnings
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #373: Suppress some "'noreturn' function does return" warnings
URL: https://github.com/apache/incubator-nuttx/pull/373#discussion_r383724700
##########
File path: arch/arm/src/common/up_pthread_start.c
##########
@@ -80,6 +80,8 @@ void up_pthread_start(pthread_startroutine_t entrypt, pthread_addr_t arg)
/* Let sys_call2() do all of the work */
sys_call2(SYS_pthread_start, (uintptr_t)entrypt, (uintptr_t)arg);
+
+ PANIC();
Review comment:
include/nuttx/arch.h has their prototypes with noreturn_function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #373:
Suppress some "'noreturn' function does return" warnings
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #373: Suppress some "'noreturn' function does return" warnings
URL: https://github.com/apache/incubator-nuttx/pull/373#discussion_r383751684
##########
File path: tools/mksyscall.c
##########
@@ -228,6 +228,11 @@ static void generate_proxy(int nparms)
fprintf(stream, "/* Auto-generated %s proxy file -- do not edit */\n\n", g_parm[NAME_INDEX]);
fprintf(stream, "#include <nuttx/config.h>\n");
+ /* Suppress "'noreturn' function does return" warnings. */
Review comment:
```suggestion
/* Suppress "'noreturn' function does return" warnings. */
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #373: Suppress some "'noreturn' function does return" warnings
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #373: Suppress some "'noreturn' function does return" warnings
URL: https://github.com/apache/incubator-nuttx/pull/373#discussion_r383712848
##########
File path: arch/arm/src/common/up_pthread_start.c
##########
@@ -80,6 +80,8 @@ void up_pthread_start(pthread_startroutine_t entrypt, pthread_addr_t arg)
/* Let sys_call2() do all of the work */
sys_call2(SYS_pthread_start, (uintptr_t)entrypt, (uintptr_t)arg);
+
+ PANIC();
Review comment:
But don't see who declare up_pthread_start/up_task_start as noreturn_function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services