[GitHub] [ozone] adoroszlai commented on a diff in pull request #3515: HDDS-6881. [SCM HA finalization] Support finalizing from a Ratis snapshot.

[GitBox <gi...@apache.org>]

adoroszlai commented on code in PR #3515:
URL: https://github.com/apache/ozone/pull/3515#discussion_r905855655


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/upgrade/FinalizationStateManagerImpl.java:
##########
@@ -172,6 +188,68 @@ public FinalizationCheckpoint getFinalizationCheckpoint() {
     return currentCheckpoint;
   }
 
+  @Override
+  public void reinitialize(Table<String, String> newFinalizationStore)
+      throws IOException {
+    checkpointLock.writeLock().lock();
+    try {
+      newFinalizationStore.close();
+      this.finalizationStore = newFinalizationStore;

Review Comment:
   Shouldn't `this.finalizationStore` be closed instead of the new one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org