You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2022/02/25 14:09:17 UTC
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18275
Change subject: [docs] Add release notes for 1.16.0
......................................................................
[docs] Add release notes for 1.16.0
Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
---
M docs/release_notes.adoc
1 file changed, 151 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/18275/1
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18275/1/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/1/docs/release_notes.adoc@210
PS1, Line 210: * The hidden `--use_hybrid_clock` flag is now tagged as unsafe as well. With
Alexey: do you think this should be added here? As it was a hidden flag, and still is, not sure we want to call it out here and bring attention to its existence.
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Fri, 25 Feb 2022 14:15:50 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 8:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/18275/6/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/6/docs/release_notes.adoc@92
PS6, Line 92: SELECT COUNT(1)
> nit: surround in back-ticks. Same elsewhere for consistency
Done
http://gerrit.cloudera.org:8080/#/c/18275/6/docs/release_notes.adoc@117
PS6, Line 117:
> Is this referring to this patch[1]? It shouldn't be specific to cmeta files
Yep, thanks for pointing this out, not sure why I wrote cmeta instead of PBC.
http://gerrit.cloudera.org:8080/#/c/18275/6/docs/release_notes.adoc@130
PS6, Line 130: ira/browse/KUDU-3311[KUDU-3311]).
:
> nit: how about "... start up a master when there is an additional master ad
Done
http://gerrit.cloudera.org:8080/#/c/18275/7/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/7/docs/release_notes.adoc@40
PS7, Line 40: New features
> Just a small observation after looking at the 'New features' sections from
Do you mean you consider all of these changes improvements rather than new features? Should we just skip the new features section? New tools, for example, are listed as new features in 1.12.0 release notes: https://kudu.apache.org/releases/1.12.0/docs/release_notes.html
http://gerrit.cloudera.org:8080/#/c/18275/7/docs/release_notes.adoc@152
PS7, Line 152: y. See
> nit: replace with 'unresolvable' ?
Done
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Tue, 01 Mar 2022 23:22:54 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18275/1/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/1/docs/release_notes.adoc@210
PS1, Line 210: * The hidden `--use_hybrid_clock` flag is now tagged as unsafe as well. With
> Alexey: do you think this should be added here? As it was a hidden flag, an
Yeah, that's a grey area :)
After some consideration I think we should remove this note, indeed. The most important factor is that the flag has been and is still hidden, so we don't have an obligation to be transparent about changes w.r.t. the --use_hybrid_clock flag.
Let's remove this, please.
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Fri, 25 Feb 2022 18:19:10 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 4:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@66
PS3, Line 66: `/startu
> nit: surround with back-ticks, as is done for `/healthz`?
Done
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@73
PS3, Line 73: * A new tool `kudu tserver unregister` is added to remove a dead tablet server
: from the cluster without restarting the masters
: (link:https://issues.apache.org/jira/browse/KUDU-2915[KUDU-2915]).
> This is a duplicate of L53?
Done
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@132
PS3, Line 132: eration` in the
> This change applies to more than just this script, right?
Done
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@136
PS3, Line 136: ve replicas to tab
> nit: surround in back-ticks?
Done
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@147
PS3, Line 147: vd.nist
> Just clarifying, we don't actually depend on Log4j in clients do we? other
SLF4J is only an abstraction layer, the underlying is still Log4J.
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Fri, 25 Feb 2022 22:30:08 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@147
PS3, Line 147: vd.nist
> Ah, for some reason I thought we relied on users to bring their own logger.
For instance, in our Java examples, we depend on slf4j-simple, rather than using log4j[1]. And it seems we only testCompile log4j everywhere except the subprocess[2]. Though I might be missing something -- I'm definitely no Java build expert
[1] https://github.com/apache/kudu/blob/master/examples/java/java-example/pom.xml#L83
[2] https://github.com/apache/kudu/search?l=Gradle&q=log4j
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Sat, 26 Feb 2022 03:36:59 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
[docs] Add release notes for 1.16.0
Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Reviewed-on: http://gerrit.cloudera.org:8080/18275
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M docs/release_notes.adoc
1 file changed, 146 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, but someone else must approve
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 1:
Rendered version: https://github.com/attilabukor/kudu/blob/branch-1.16.x/docs/release_notes.adoc
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Fri, 25 Feb 2022 14:15:02 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18275/7/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/7/docs/release_notes.adoc@40
PS7, Line 40: New features
Just a small observation after looking at the 'New features' sections from prior releases: it seems to me that all current items here would be in the 'Optimizations and improvements' section if we used the same approach as in prior releases :)
But I think it's totally fine to have the information represented as in these notes.
http://gerrit.cloudera.org:8080/#/c/18275/7/docs/release_notes.adoc@152
PS7, Line 152: unreachable
nit: replace with 'unresolvable' ?
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Tue, 01 Mar 2022 18:13:37 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Khazar Mammadli, Will Berkeley, Zoltan Chovan, Riza Suminto, Hongjiang Zhang, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, yejiabao, KeDeng, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18275
to look at the new patch set (#2).
Change subject: [docs] Add release notes for 1.16.0
......................................................................
[docs] Add release notes for 1.16.0
Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
---
M docs/release_notes.adoc
1 file changed, 148 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/18275/2
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18275/1/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/1/docs/release_notes.adoc@210
PS1, Line 210: * The hidden `--use_hybrid_clock` flag is now tagged as unsafe as well. With
> Yeah, that's a grey area :)
I agree, glad we're on the same page :) deleted it, thanks.
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Fri, 25 Feb 2022 19:02:11 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Khazar Mammadli, Will Berkeley, Zoltan Chovan, Riza Suminto, Hongjiang Zhang, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, yejiabao, KeDeng, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18275
to look at the new patch set (#6).
Change subject: [docs] Add release notes for 1.16.0
......................................................................
[docs] Add release notes for 1.16.0
Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
---
M docs/release_notes.adoc
1 file changed, 146 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/18275/6
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@147
PS3, Line 147: vd.nist
> SLF4J is only an abstraction layer, the underlying is still Log4J.
Ah, for some reason I thought we relied on users to bring their own logger.
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Sat, 26 Feb 2022 00:41:50 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@66
PS3, Line 66: * It’s now possible to track startup progress on the `/startup` page on the web
: UI (link:https://issues.apache.org/jira/browse/KUDU-1959[KUDU-1959
> It's probably also worth mentioning the startup metrics. WDYT? cc Abhishek
Yes, I think we can add the below at the of the sentence:
`/startup` page on the web UI. There are also metrics added to track the overall server startup progress as well as the processing of the log block containers and starting of the tablets.
http://gerrit.cloudera.org:8080/#/c/18275/5/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/5/docs/release_notes.adoc@233
PS5, Line 233: 2
5?
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Mon, 28 Feb 2022 20:33:35 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Khazar Mammadli, Will Berkeley, Zoltan Chovan, Riza Suminto, Hongjiang Zhang, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, yejiabao, KeDeng, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18275
to look at the new patch set (#3).
Change subject: [docs] Add release notes for 1.16.0
......................................................................
[docs] Add release notes for 1.16.0
Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
---
M docs/release_notes.adoc
1 file changed, 148 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/18275/3
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@66
PS3, Line 66: /startup
nit: surround with back-ticks, as is done for `/healthz`?
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@66
PS3, Line 66: * It’s now possible to track startup progress on the /startup page on the web UI
: (link:https://issues.apache.org/jira/browse/KUDU-1959[KUDU-1959]).
It's probably also worth mentioning the startup metrics. WDYT? cc Abhishek
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@73
PS3, Line 73: * A new tool `kudu table set_replication_factor` is added to change the
: replication factor of an existing table
: (link:https://issues.apache.org/jira/browse/KUDU-3304[KUDU-3304]).
This is a duplicate of L53?
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@132
PS3, Line 132: `start_kudu.sh`
This change applies to more than just this script, right?
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@136
PS3, Line 136: KuduWriteOperation
nit: surround in back-ticks?
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@147
PS3, Line 147: clients
Just clarifying, we don't actually depend on Log4j in clients do we? other than in tests? I thought we use slf4j
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Fri, 25 Feb 2022 22:05:10 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Khazar Mammadli, Will Berkeley, Zoltan Chovan, Riza Suminto, Hongjiang Zhang, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, yejiabao, KeDeng, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18275
to look at the new patch set (#7).
Change subject: [docs] Add release notes for 1.16.0
......................................................................
[docs] Add release notes for 1.16.0
Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
---
M docs/release_notes.adoc
1 file changed, 146 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/18275/7
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Wed, 02 Mar 2022 17:50:19 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@66
PS3, Line 66: * It’s now possible to track startup progress on the `/startup` page on the web
: UI. There are also metrics added to track the overall server start
> Yes, I think we can add the below at the of the sentence:
Done
http://gerrit.cloudera.org:8080/#/c/18275/5/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/5/docs/release_notes.adoc@233
PS5, Line 233:
> 5?
Thanks, I guess it was upside down :)
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Mon, 28 Feb 2022 21:26:56 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18275/7/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/7/docs/release_notes.adoc@40
PS7, Line 40: New features
> Do you mean you consider all of these changes improvements rather than new
Ah, probably, I was looking at a very small set of release notes -- checked 1.3.0, 1.6.0 and 1.9.0. Those had sort of 'heavier' features, but not so rich in terms of overall number new functionality items.
Yes, overall looks good to me: indeed, in several releases new CLI tools were reflected as new features, and indeed they should be considered as such from the conceptual point.
Looks good to me!
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Wed, 02 Mar 2022 00:15:21 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@66
PS3, Line 66: * It’s now possible to track startup progress on the `/startup` page on the web
: UI. There are also metrics added to track the overall server start
> Seems this was reverted in revision 8
Thanks, seems I didn't check out the latest before I made the change on my other MacBook :(
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Wed, 02 Mar 2022 07:30:27 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Khazar Mammadli, Will Berkeley, Zoltan Chovan, Riza Suminto, Hongjiang Zhang, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, yejiabao, KeDeng, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18275
to look at the new patch set (#9).
Change subject: [docs] Add release notes for 1.16.0
......................................................................
[docs] Add release notes for 1.16.0
Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
---
M docs/release_notes.adoc
1 file changed, 146 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/18275/9
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Khazar Mammadli, Will Berkeley, Zoltan Chovan, Riza Suminto, Hongjiang Zhang, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, yejiabao, KeDeng, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18275
to look at the new patch set (#4).
Change subject: [docs] Add release notes for 1.16.0
......................................................................
[docs] Add release notes for 1.16.0
Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
---
M docs/release_notes.adoc
1 file changed, 144 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/18275/4
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Khazar Mammadli, Will Berkeley, Zoltan Chovan, Riza Suminto, Hongjiang Zhang, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, yejiabao, KeDeng, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18275
to look at the new patch set (#5).
Change subject: [docs] Add release notes for 1.16.0
......................................................................
[docs] Add release notes for 1.16.0
Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
---
M docs/release_notes.adoc
1 file changed, 144 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/18275/5
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@147
PS3, Line 147: vd.nist
> For instance, in our Java examples, we depend on slf4j-simple, rather than
You're right, we don't ship log4j in the client, only in the subprocess, changed it.
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Sat, 26 Feb 2022 10:55:48 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Alexey Serbin, Yuqi Du, Yingchun Lai, Yifan Zhang, Khazar Mammadli, Will Berkeley, Zoltan Chovan, Riza Suminto, Hongjiang Zhang, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, yejiabao, KeDeng, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18275
to look at the new patch set (#8).
Change subject: [docs] Add release notes for 1.16.0
......................................................................
[docs] Add release notes for 1.16.0
Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
---
M docs/release_notes.adoc
1 file changed, 144 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/18275/8
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Fri, 25 Feb 2022 23:47:52 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Wed, 02 Mar 2022 17:33:06 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 8:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/3/docs/release_notes.adoc@66
PS3, Line 66: * It’s now possible to track startup progress on the `/startup` page on the web
: UI (link:https://issues.apache.org/jira/browse/KUDU-1959[KUDU-1959
> Done
Seems this was reverted in revision 8
http://gerrit.cloudera.org:8080/#/c/18275/6/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/6/docs/release_notes.adoc@117
PS6, Line 117:
> Yep, thanks for pointing this out, not sure why I wrote cmeta instead of PB
Seems this was reverted in revision 8
http://gerrit.cloudera.org:8080/#/c/18275/6/docs/release_notes.adoc@130
PS6, Line 130: ira/browse/KUDU-3311[KUDU-3311]).
:
> Done
Seems this was reverted in revision 8
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Wed, 02 Mar 2022 00:26:12 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18275/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/2/docs/release_notes.adoc@122
PS2, Line 122: confiugrable
configurable
http://gerrit.cloudera.org:8080/#/c/18275/2/docs/release_notes.adoc@126
PS2, Line 126: webinterfaces
Maybe, replace 'webinterfaces' with 'embedded web servers' ?
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Fri, 25 Feb 2022 21:41:32 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18275/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/2/docs/release_notes.adoc@122
PS2, Line 122: configurable
> configurable
Done
http://gerrit.cloudera.org:8080/#/c/18275/2/docs/release_notes.adoc@126
PS2, Line 126: embedded web
> Maybe, replace 'webinterfaces' with 'embedded web servers' ?
Done
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Fri, 25 Feb 2022 21:46:14 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 )
Change subject: [docs] Add release notes for 1.16.0
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18275/6/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/18275/6/docs/release_notes.adoc@92
PS6, Line 92: --row_count_only
nit: surround in back-ticks. Same elsewhere for consistency
http://gerrit.cloudera.org:8080/#/c/18275/6/docs/release_notes.adoc@117
PS6, Line 117: cmeta
Is this referring to this patch[1]? It shouldn't be specific to cmeta files, I don't think
[1] https://gerrit.cloudera.org/c/17808/
http://gerrit.cloudera.org:8080/#/c/18275/6/docs/release_notes.adoc@130
PS6, Line 130: cluster with if +1 master address is present
: in the flags
nit: how about "... start up a master when there is an additional master address present in the master addresses flag."
--
To view, visit http://gerrit.cloudera.org:8080/18275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32
Gerrit-Change-Number: 18275
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hongjiang Zhang <ho...@ebay.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: yejiabao <ye...@huawei.com>
Gerrit-Comment-Date: Mon, 28 Feb 2022 21:38:38 +0000
Gerrit-HasComments: Yes