[GitHub] [hadoop] mukund-thakur commented on a change in pull request #2425: HADOOP-17332. S3A MarkerTool -min and -max are inverted.

[GitBox <gi...@apache.org>]

mukund-thakur commented on a change in pull request #2425:
URL: https://github.com/apache/hadoop/pull/2425#discussion_r522641678



##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java
##########
@@ -513,6 +526,11 @@ private ScanResult scan(
       final DirectoryPolicy filterPolicy)
       throws IOException, ExitUtil.ExitException {
 
+    // safety check: min and max are correctly ordered at this point.
+    Preconditions.checkArgument(minMarkerCount <= maxMarkerCount,

Review comment:
       nit: Is this check required again since we have already swapped above?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org