You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "KamranImaaz (via GitHub)" <gi...@apache.org> on 2026/02/07 07:11:53 UTC
[PR] Fix docs compute.rst [airflow]
KamranImaaz opened a new pull request, #61574:
URL: https://github.com/apache/airflow/pull/61574
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
This PR modifes the changes in Compute.rst file adjust the headings and remove the `arguments` keyword
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align Google Cloud Compute operator documentation headings with RST style [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 merged PR #61574:
URL: https://github.com/apache/airflow/pull/61574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align Google Cloud Compute operator documentation headings with RST style [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61574:
URL: https://github.com/apache/airflow/pull/61574#issuecomment-3863970006
I don't know why this checks are failing as it is not related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align Google Cloud Compute operator documentation headings with RST style [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on PR #61574:
URL: https://github.com/apache/airflow/pull/61574#issuecomment-3864333822
This PR is good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix docs compute.rst [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on code in PR #61574:
URL: https://github.com/apache/airflow/pull/61574#discussion_r2777255718
##########
providers/google/docs/operators/cloud/bigquery.rst:
##########
@@ -208,6 +208,10 @@ nesting will a nested list where elements would represent the column values for
that row.
``True`` - A Python list of dictionaries, where each dictionary represents a row. In each dictionary, the keys are the column names and the values are the corresponding values for those columns.
+..note::
+The project_id parameter is deprecated and will be removed in a future release.
+Please use table_project_id instead.
+
Review Comment:
Yes I am working on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align Google Cloud Compute operator documentation headings with RST style [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #61574:
URL: https://github.com/apache/airflow/pull/61574#issuecomment-3863982407
> I don't know why this checks are failing as it is not related to this PR
Indeed not related, I'm taking care of it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix docs compute.rst [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #61574:
URL: https://github.com/apache/airflow/pull/61574#discussion_r2777250986
##########
providers/google/docs/operators/cloud/bigquery.rst:
##########
@@ -208,6 +208,10 @@ nesting will a nested list where elements would represent the column values for
that row.
``True`` - A Python list of dictionaries, where each dictionary represents a row. In each dictionary, the keys are the column names and the values are the corresponding values for those columns.
+..note::
+The project_id parameter is deprecated and will be removed in a future release.
+Please use table_project_id instead.
+
Review Comment:
Seems unnrelated to this PR and duplicates an existing comment from above - please remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align Google Cloud Compute operator documentation headings with RST style [airflow]
Posted by "KamranImaaz (via GitHub)" <gi...@apache.org>.
KamranImaaz commented on code in PR #61574:
URL: https://github.com/apache/airflow/pull/61574#discussion_r2777264280
##########
providers/google/docs/operators/cloud/bigquery.rst:
##########
@@ -208,6 +208,10 @@ nesting will a nested list where elements would represent the column values for
that row.
``True`` - A Python list of dictionaries, where each dictionary represents a row. In each dictionary, the keys are the column names and the values are the corresponding values for those columns.
+..note::
+The project_id parameter is deprecated and will be removed in a future release.
+Please use table_project_id instead.
+
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org