You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/14 18:41:21 UTC

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1208: [HUDI-304] Bring back spotless plugin

bvaradar commented on a change in pull request #1208: [HUDI-304] Bring back spotless plugin
URL: https://github.com/apache/incubator-hudi/pull/1208#discussion_r366507169
 
 

 ##########
 File path: hudi-cli/src/main/java/org/apache/hudi/cli/HoodieCLI.java
 ##########
 @@ -64,8 +64,8 @@ private static void setBasePath(String basePath) {
   }
 
   private static void setLayoutVersion(Integer layoutVersion) {
-    HoodieCLI.layoutVersion = new TimelineLayoutVersion(
-        (layoutVersion == null) ? TimelineLayoutVersion.CURR_VERSION : layoutVersion);
+    HoodieCLI.layoutVersion =
 
 Review comment:
   For example, I am quoting this line. Do you know what rule in eclipse created this change. As checkstyle never enforced it, can we remove this rule ? Please take a look at other changes to see if there is any other pattern like this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services