[GitHub] [hadoop] leosunli commented on a change in pull request #1223: HADOOP-16112. Delete the baseTrashPath's subDir leads to don't modify baseTrashPath

[GitBox <gi...@apache.org>]

leosunli commented on a change in pull request #1223: HADOOP-16112. Delete the baseTrashPath's subDir leads to don't modify baseTrashPath
URL: https://github.com/apache/hadoop/pull/1223#discussion_r312572367
 
 

 ##########
 File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
 ##########
 @@ -171,6 +171,13 @@
   public static final String  FS_TRASH_INTERVAL_KEY = "fs.trash.interval";
   /** Default value for FS_TRASH_INTERVAL_KEY */
   public static final long    FS_TRASH_INTERVAL_DEFAULT = 0;
+
+  public static final String MOVE_TO_TRASH_FOR_TEST_KEY = "move.to.trash.for.tests";
 
 Review comment:
   @jojochuang  MOVE_TO_TRASH_FOR_TEST_KEY，
   This configuration is used as a switch. The default is off. It is only turned on when the unit is tested. It is the logic that is executed in the unit test. Other people write the same.What better advice do you have?Thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org