You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2013/01/03 03:53:09 UTC
Re: Review Request: [Doc] HCat EL functions user twiki
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8769/
-----------------------------------------------------------
(Updated Jan. 3, 2013, 2:53 a.m.)
Review request for oozie.
Changes
-------
Improved example illustration with layout and details
The html file can be checked for formatting and links, by downloading patch
Description
-------
See OOZIE-1123 for HCat EL functions description and implementation. This patch is user documentation for usage
Diffs (updated)
-----
branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html PRE-CREATION
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 1426606
Diff: https://reviews.apache.org/r/8769/diff/
Testing
-------
n/a
Thanks,
Mona Chitnis
Re: Review Request: [Doc] HCat EL functions user twiki
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8769/#review15076
-----------------------------------------------------------
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/8769/#comment32655>
You will also need to add a section here
- Rohini Palaniswamy
On Jan. 3, 2013, 2:53 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8769/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2013, 2:53 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> See OOZIE-1123 for HCat EL functions description and implementation. This patch is user documentation for usage
>
>
> Diffs
> -----
>
> branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html PRE-CREATION
> branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 1426606
>
> Diff: https://reviews.apache.org/r/8769/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [Doc] HCat EL functions user twiki
Posted by Mona Chitnis <mo...@yahoo.in>.
> On Jan. 3, 2013, 6:20 p.m., Rohini Palaniswamy wrote:
> > Can we order all the dataIn functions first followed by dataOut?
showing dataOut is needed to make both examples complete and usable directly. the second example then goes on to show min, max and dataOut for particular partition which are like additional convenience functions
> On Jan. 3, 2013, 6:20 p.m., Rohini Palaniswamy wrote:
> > branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html, line 3477
> > <https://reviews.apache.org/r/8769/diff/2/?file=244499#file244499line3477>
> >
> > The EL function should not be adding the quotes. if that's case can you fix the EL function and update the example by putting the quotes manually - That is the first comment when I read this. Then realized you were just mentioning how arguments are passed to pig. Kind of confusing as to whether you need to put quotes or not. Would be better to remove the comment as the example is clear on the usage.
removing the comment to avoid confusion
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8769/#review15030
-----------------------------------------------------------
On Jan. 3, 2013, 2:53 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8769/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2013, 2:53 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> See OOZIE-1123 for HCat EL functions description and implementation. This patch is user documentation for usage
>
>
> Diffs
> -----
>
> branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html PRE-CREATION
> branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 1426606
>
> Diff: https://reviews.apache.org/r/8769/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [Doc] HCat EL functions user twiki
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8769/#review15030
-----------------------------------------------------------
Can we order all the dataIn functions first followed by dataOut?
branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html
<https://reviews.apache.org/r/8769/#comment32566>
"Refer to the Example below for usage". Other places too.
branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html
<https://reviews.apache.org/r/8769/#comment32567>
action tag in next line
branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html
<https://reviews.apache.org/r/8769/#comment32568>
Can we move this not to dataInPartitionPigFilter section
branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html
<https://reviews.apache.org/r/8769/#comment32569>
The EL function should not be adding the quotes. if that's case can you fix the EL function and update the example by putting the quotes manually - That is the first comment when I read this. Then realized you were just mentioning how arguments are passed to pig. Kind of confusing as to whether you need to put quotes or not. Would be better to remove the comment as the example is clear on the usage.
branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html
<https://reviews.apache.org/r/8769/#comment32570>
$region here too
branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html
<https://reviews.apache.org/r/8769/#comment32571>
Can you also add datestamp to this example along with region. Does not make sense if the uri definition has datestamp and it is not used here.
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/8769/#comment32573>
coordinator actions running workflows?
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/8769/#comment32574>
remove commonly
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/8769/#comment32575>
Remove commonly
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/8769/#comment32576>
The filter clause format is specific to pig and hence the EL function name.... - note here.
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/8769/#comment32577>
for the output-event dataset. This can be passed as an argument to HCatStorer in pig scripts.
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/8769/#comment32578>
using the EL functions.
input partitions pig filter
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/8769/#comment32579>
Can we make it 24 instead of 5 to make it consistent with hourly to daily processing
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/8769/#comment32581>
Add a note asking to use dataInPartitionMin and Max to form a range fitler wherever possible instead of datainPartitionPigFilter as it will be more efficient for filtering.
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/8769/#comment32572>
Can you also mention here, that this is another convenience function in addition to dataoutPartitions and either one can be used.
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/8769/#comment32580>
remove ofcourse
- Rohini Palaniswamy
On Jan. 3, 2013, 2:53 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8769/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2013, 2:53 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> See OOZIE-1123 for HCat EL functions description and implementation. This patch is user documentation for usage
>
>
> Diffs
> -----
>
> branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html PRE-CREATION
> branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 1426606
>
> Diff: https://reviews.apache.org/r/8769/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [Doc] HCat EL functions user twiki
Posted by Mona Chitnis <mo...@yahoo.in>.
> On Jan. 7, 2013, 11:28 p.m., Rohini Palaniswamy wrote:
> > branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki, line 2426
> > <https://reviews.apache.org/r/8769/diff/2-3/?file=244500#file244500line2426>
> >
> > =dataInPartitionMax=
Committed after fixing this word. Thanks
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8769/#review15128
-----------------------------------------------------------
On Jan. 7, 2013, 8:54 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8769/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2013, 8:54 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> See OOZIE-1123 for HCat EL functions description and implementation. This patch is user documentation for usage
>
>
> Diffs
> -----
>
> branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html PRE-CREATION
> branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 1429987
>
> Diff: https://reviews.apache.org/r/8769/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [Doc] HCat EL functions user twiki
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8769/#review15128
-----------------------------------------------------------
Ship it!
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
<https://reviews.apache.org/r/8769/#comment32721>
=dataInPartitionMax=
- Rohini Palaniswamy
On Jan. 7, 2013, 8:54 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8769/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2013, 8:54 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> See OOZIE-1123 for HCat EL functions description and implementation. This patch is user documentation for usage
>
>
> Diffs
> -----
>
> branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html PRE-CREATION
> branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 1429987
>
> Diff: https://reviews.apache.org/r/8769/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [Doc] HCat EL functions user twiki
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8769/#review15139
-----------------------------------------------------------
Ship it!
+1..looks nice
- Virag Kothari
On Jan. 7, 2013, 8:54 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8769/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2013, 8:54 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> See OOZIE-1123 for HCat EL functions description and implementation. This patch is user documentation for usage
>
>
> Diffs
> -----
>
> branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html PRE-CREATION
> branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 1429987
>
> Diff: https://reviews.apache.org/r/8769/diff/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: [Doc] HCat EL functions user twiki
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8769/
-----------------------------------------------------------
(Updated Jan. 7, 2013, 8:54 p.m.)
Review request for oozie.
Changes
-------
Incorporated Rohini's comments.
Description
-------
See OOZIE-1123 for HCat EL functions description and implementation. This patch is user documentation for usage
Diffs (updated)
-----
branches/hcat-intre/docs/src/site/CoordinatorFunctionalSpec.html PRE-CREATION
branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 1429987
Diff: https://reviews.apache.org/r/8769/diff/
Testing
-------
n/a
Thanks,
Mona Chitnis