[GitHub] [trafficcontrol] mitchell852 opened a new issue #5493: GET /servers?dsId={{dsId}} not filtering out cache server w/o required server capabilities

[GitBox <gi...@apache.org>]

mitchell852 opened a new issue #5493:
URL: https://github.com/apache/trafficcontrol/issues/5493


   ## I'm submitting a ...
   -  bug report
   
   ## Traffic Control components affected ...
   -  Traffic Ops
   
   ## Current behavior:
   GET /servers?dsId={{dsId}} is returning mids that do not have the ds's required server capabilities.
   
   ## Expected behavior:
   If a delivery service requires one or more server capabilities, the results of GET /servers?dsId={{dsId}} should never include cache servers (edges or mids) that do not have all of the ds's required server capabilities. ORG servers are different thanks to MSO and are returned regardless.
   
   ## Minimal reproduction of the problem with instructions:
   - create a ds that employs both the edge and mid tier. i.e. a DNS delivery service
   - add a required server capability to the ds
   - add the same server capability to a handful of edge servers (ensure those edge servers are in a cache group that is parented by a mid cache group)
   - GET /servers?dsId={{dsId}} and notice that the mids are returned when the mids were never assigned the server capability
   
   ## Anything else:
   Note: this does not seem to affect the behavior of "server capabilities" which was designed to include/exclude cache servers (edges/mids) from the crconfig (snapshot) and relevant ats config files (parent.config).
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 commented on issue #5493: GET /servers?dsId={{dsId}} not filtering out cache servers (edges/mids) w/o required server capabilities

[GitBox <gi...@apache.org>]

mitchell852 commented on issue #5493:
URL: https://github.com/apache/trafficcontrol/issues/5493#issuecomment-772725637


   looks like the root of the problem is probably in here:
   
   https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/server/servers.go#L1218
   
   ^^ the query does not exclude mids that don't have the required server capability.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman closed issue #5493: GET /servers?dsId={{dsId}} not filtering out cache servers (edges/mids) w/o required server capabilities

[GitBox <gi...@apache.org>]

zrhoffman closed issue #5493:
URL: https://github.com/apache/trafficcontrol/issues/5493


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] srijeet0406 commented on issue #5493: GET /servers?dsId={{dsId}} not filtering out cache servers (edges/mids) w/o required server capabilities

[GitBox <gi...@apache.org>]

srijeet0406 commented on issue #5493:
URL: https://github.com/apache/trafficcontrol/issues/5493#issuecomment-775267088


   I can take this one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org