[jira] [Commented] (UIMA-5046) Faster indexCovered implementation

["James Baker (JIRA)" <de...@uima.apache.org>]

    [ https://issues.apache.org/jira/browse/UIMA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959064#comment-15959064 ] 

James Baker commented on UIMA-5046:
-----------------------------------

This seems to have introduced a change of behaviour when both types are the same. In v2.2.0, running JCasUtil.indexCovered(jCas, MyType.class, MyType.class) did not include an annotation as covering itself. However, in v2.3.0 it does.

Is this intended behaviour, and if so should it be documented somewhere? If it isn't, I'm happy to file a bug report for the issue so it can be addressed in future releases.

> Faster indexCovered implementation
> ----------------------------------
>
>                 Key: UIMA-5046
>                 URL: https://issues.apache.org/jira/browse/UIMA-5046
>             Project: UIMA
>          Issue Type: Improvement
>          Components: uimaFIT
>            Reporter: Richard Eckart de Castilho
>            Assignee: Richard Eckart de Castilho
>             Fix For: 2.3.0uimaFIT
>
>
> CasUtil.indexCovered() currently uses a quite naive approach of going over all of the covering candidate annotations and calling selectCovered for each of them. This can be done smarter by iterating simultaneously over the covering and covered type while maintaining a memory in which only the potentially covering annotations are maintained and compared against the covered annotations. Any annotation of the covering type can be purged from this memory once it cannot match any covering annotation anymore. This approach exploits the sort order inherent in the annotation index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)