You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "gfphoenix78 (via GitHub)" <gi...@apache.org> on 2026/06/03 01:58:14 UTC
[PR] Fix parallel retrieve cursor check timeout never going quiet [cloudberry]
gfphoenix78 opened a new pull request, #1796:
URL: https://github.com/apache/cloudberry/pull/1796
GP_PARALLEL_RETRIEVE_CURSOR_CHECK_TIMEOUT was armed by every DECLARE PARALLEL RETRIEVE CURSOR but had no path to ever be disabled: the handler re-armed it unconditionally in the !DoingCommandRead branch, and no portal-drop path ever called disable_timeout(). The result was a SIGALRM firing every 10 seconds for the rest of the backend's life even when no parallel retrieve cursors remained, which interfered with unrelated code paths (e.g. truncating pg_usleep-based fault sleeps that tests rely on).
Tighten this in two ways:
- The handler now only re-arms when GetNumOfParallelRetrieveCursors() is still positive, so the timer naturally quiets after the last cursor is gone.
- PortalCleanup() proactively calls disable_timeout() when the last parallel retrieve cursor in this backend is being torn down, avoiding even the single stray firing that the handler fallback would otherwise still produce.
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix parallel retrieve cursor check timeout never going quiet [cloudberry]
Posted by "gfphoenix78 (via GitHub)" <gi...@apache.org>.
gfphoenix78 commented on code in PR #1796:
URL: https://github.com/apache/cloudberry/pull/1796#discussion_r3346517978
##########
src/backend/utils/init/postinit.c:
##########
Review Comment:
No, the handler is only used on QD, not QE. All the handlers are registered unconditionally. It's harmless to register it on QE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix parallel retrieve cursor check timeout never going quiet [cloudberry]
Posted by "my-ship-it (via GitHub)" <gi...@apache.org>.
my-ship-it commented on code in PR #1796:
URL: https://github.com/apache/cloudberry/pull/1796#discussion_r3346534881
##########
src/backend/utils/init/postinit.c:
##########
Review Comment:
> No, the handler is only used on QD, not QE. All the handlers are registered unconditionally. It's harmless to register it on QE
LGTM since it is harmless, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix parallel retrieve cursor check timeout never going quiet [cloudberry]
Posted by "my-ship-it (via GitHub)" <gi...@apache.org>.
my-ship-it commented on code in PR #1796:
URL: https://github.com/apache/cloudberry/pull/1796#discussion_r3345721136
##########
src/backend/utils/init/postinit.c:
##########
Review Comment:
Should GpParallelRetrieveCursorCheckTimeoutHandler be registered only for QE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org