You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/24 03:55:34 UTC

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5136: apiserver : Ensure required parameters are not empty

GabrielBrascher commented on a change in pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#discussion_r657604209



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java
##########
@@ -94,7 +94,6 @@
 
     @Parameter(name = ApiConstants.SUPPORTED_SERVICES,
             type = CommandType.LIST,
-            required = true,

Review comment:
       Is there any update on the API command [createNetworkOffering](https://cloudstack.apache.org/api/apidocs-4.15/apis/createNetworkOffering.html) that I am not aware of?
   As far as I know, `supportedservices` is required.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org