You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/22 10:25:55 UTC

[GitHub] [shardingsphere] zhaoguhong opened a new issue, #22342: ComplexKeysShardingValue add DataNodeInfo

zhaoguhong opened a new issue, #22342:
URL: https://github.com/apache/shardingsphere/issues/22342

   I extend the complex  sharding algorithm need DataNodeInfo, but it only in `org.apache.shardingsphere.sharding.api.sharding.standard.PreciseShardingValue`
   
   I think can add DataNodeInfo for `org.apache.shardingsphere.sharding.api.sharding.complex.ComplexKeysShardingValue`
   
   
   ### before
   ```java
   @RequiredArgsConstructor
   @Getter
   @ToString
   public final class ComplexKeysShardingValue<T extends Comparable<?>> implements ShardingValue {
       
       private final String logicTableName;
       
       private final Map<String, Collection<T>> columnNameAndShardingValuesMap;
       
       private final Map<String, Range<T>> columnNameAndRangeValuesMap;
       
   }
   ```
   ### after
   ```java
   @RequiredArgsConstructor
   @Getter
   @ToString
   public final class ComplexKeysShardingValue<T extends Comparable<?>> implements ShardingValue {
       
       private final String logicTableName;
       
       private final Map<String, Collection<T>> columnNameAndShardingValuesMap;
       
       private final Map<String, Range<T>> columnNameAndRangeValuesMap;
   
       private final DataNodeInfo dataNodeInfo;
       
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhaoguhong commented on issue #22342: ComplexKeysShardingValue add DataNodeInfo

Posted by GitBox <gi...@apache.org>.
zhaoguhong commented on issue #22342:
URL: https://github.com/apache/shardingsphere/issues/22342#issuecomment-1328665591

   After discussion，It`s not universal


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhaoguhong closed issue #22342: ComplexKeysShardingValue add DataNodeInfo

Posted by GitBox <gi...@apache.org>.
zhaoguhong closed issue #22342: ComplexKeysShardingValue add DataNodeInfo
URL: https://github.com/apache/shardingsphere/issues/22342


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org