You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/03 14:12:25 UTC
[GitHub] [cloudstack] slavkap opened a new pull request #5072: Fix of some UEFI related issues
slavkap opened a new pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072
### Description
This PR fixes
1 - fix of attaching/detaching ISO of VM with UEFI boot type, which was introduced in #4773
2 - if the OS type of an ISO is categorized as "Other", the bus type of the disk
will be set to "SATA" because we don't know what OS is behind "Other".
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X ] Minor
- [ ] Trivial
### How Has This Been Tested?
manual tests with CentOS8 and Windows 10 ISOs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-856432883
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-855790232
@Pearl1594 (or anyone else) have you tested this? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-853906601
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-856432811
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-853906601
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on a change in pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
slavkap commented on a change in pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#discussion_r646815099
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -3459,6 +3457,8 @@ public boolean isCentosHost() {
platformEmulator.startsWith("Oracle") ||
platformEmulator.startsWith("Other PV")) {
return DiskDef.DiskBus.VIRTIO;
+ } else if (isUefiEnabled && (platformEmulator.startsWith("Windows") || platformEmulator.startsWith("Other"))) {
Review comment:
@GutoVeronezi, I saw your suggestion, and I like it, but I'm not sure that I have to do it. The first is because I was following the rest of the statement to be in the "same style", and it's a small fix, not a refactoring. Another thing is in `LibvirtComputingResource` is used `com.cloud.utils.StringUtils` and `org.apache.commons.lang.StringUtils`, for me, it's going to be a mess if we use and `commons.lang3`.
Anyway, I will make the change :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#discussion_r646640959
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -3459,6 +3457,8 @@ public boolean isCentosHost() {
platformEmulator.startsWith("Oracle") ||
platformEmulator.startsWith("Other PV")) {
return DiskDef.DiskBus.VIRTIO;
+ } else if (isUefiEnabled && (platformEmulator.startsWith("Windows") || platformEmulator.startsWith("Other"))) {
Review comment:
To simplify those validations, we could use `StringUtils.startsWithAny`, from `commons.lang3`:
```java
StringUtils.startsWithAny(platformEmulator, ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-853969080
@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-856532671
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-855635755
@harikrishna-patnala, yes, it was reverted. I spoke with @Pearl1594 that it was reverted while rebasing another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-854364237
<b>Trillian test result (tid-843)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45695 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5072-t843-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3626.33 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3605.69 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.12 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 111.92 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-856996110
<b>Trillian test result (tid-894)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37390 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5072-t894-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-856441833
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-853907105
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-856532359
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-853928680
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-853967981
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-853907105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5072: Fix of some UEFI related issues
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-853967981
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org