You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/03/20 02:27:21 UTC
Review Request 70244: Added new operation reconciliation tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
Bugs: MESOS-9318
https://issues.apache.org/jira/browse/MESOS-9318
Repository: mesos
Description
-------
This patch adds two new operation reconciliation tests,
`OperationOnUnsubscribedProvider` and
`FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
probe scenarios relevant to MESOS-9648 and MESOS-9318.
Diffs
-----
src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
Diff: https://reviews.apache.org/r/70244/diff/1/
Testing
-------
`make check`
`bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
`bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213854
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70200, 70208, 70221, 70242, 70243, 70244]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2019, 12:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 12:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review214018
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On March 22, 2019, 7:35 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 7:35 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 8bd1dc02a74c4e6c1b97b25e73098c0b75f2d38e
>
>
> Diff: https://reviews.apache.org/r/70244/diff/3/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213943
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70264, 70242, 70243, 70244]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 23, 2019, 2:35 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 23, 2019, 2:35 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 8bd1dc02a74c4e6c1b97b25e73098c0b75f2d38e
>
>
> Diff: https://reviews.apache.org/r/70244/diff/3/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213944
-----------------------------------------------------------
PASS: Mesos patch 70244 was successfully built and tested.
Reviews applied: `['70264', '70242', '70243', '70244']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3003/mesos-review-70244
- Mesos Reviewbot Windows
On March 23, 2019, 2:35 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 23, 2019, 2:35 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 8bd1dc02a74c4e6c1b97b25e73098c0b75f2d38e
>
>
> Diff: https://reviews.apache.org/r/70244/diff/3/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/
-----------------------------------------------------------
(Updated March 23, 2019, 2:35 a.m.)
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
Bugs: MESOS-9318
https://issues.apache.org/jira/browse/MESOS-9318
Repository: mesos
Description
-------
This patch adds two new operation reconciliation tests,
`OperationOnUnsubscribedProvider` and
`FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
probe scenarios relevant to MESOS-9648 and MESOS-9318.
Diffs (updated)
-----
src/tests/operation_reconciliation_tests.cpp 8bd1dc02a74c4e6c1b97b25e73098c0b75f2d38e
Diff: https://reviews.apache.org/r/70244/diff/3/
Changes: https://reviews.apache.org/r/70244/diff/2-3/
Testing
-------
`make check`
`bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
`bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Greg Mann <gr...@mesosphere.io>.
> On March 21, 2019, 11:39 p.m., Joseph Wu wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 1706-1707 (patched)
> > <https://reviews.apache.org/r/70244/diff/2/?file=2133044#file2133044line1706>
> >
> > I'm not seeing a clear race in the test body.
> >
> > The `UpdateSlaveMessage` right before the operation reconciliation is properly waited for before the reconciliation starts. So the master would already know about the agent, and the agent's RP.
I had to change the test to restart the master to clear out the operation state, and now I drop the UpdateSlaveMessage so that the master doesn't know about the RP.
> On March 21, 2019, 11:39 p.m., Joseph Wu wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 1889-1903 (patched)
> > <https://reviews.apache.org/r/70244/diff/2/?file=2133044#file2133044line1889>
> >
> > Is it possible to intercept the message forwarded between master and agent? There doesn't seem to be strong evidence that the master actually asked the agent for the latest status.
I added a FUTURE_PROTOBUF call to look for the ReconcileOperationsMessage.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213894
-----------------------------------------------------------
On March 23, 2019, 2:35 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 23, 2019, 2:35 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 8bd1dc02a74c4e6c1b97b25e73098c0b75f2d38e
>
>
> Diff: https://reviews.apache.org/r/70244/diff/3/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213894
-----------------------------------------------------------
+1 on the first test. Some questions on the second one.
src/tests/operation_reconciliation_tests.cpp
Lines 1576-1578 (patched)
<https://reviews.apache.org/r/70244/#comment300007>
Extra newline. Although I think this is a copy-pasta error in this file or in similar tests.
src/tests/operation_reconciliation_tests.cpp
Lines 1706-1707 (patched)
<https://reviews.apache.org/r/70244/#comment300009>
I'm not seeing a clear race in the test body.
The `UpdateSlaveMessage` right before the operation reconciliation is properly waited for before the reconciliation starts. So the master would already know about the agent, and the agent's RP.
src/tests/operation_reconciliation_tests.cpp
Lines 1889-1903 (patched)
<https://reviews.apache.org/r/70244/#comment300010>
Is it possible to intercept the message forwarded between master and agent? There doesn't seem to be strong evidence that the master actually asked the agent for the latest status.
- Joseph Wu
On March 20, 2019, 12:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 12:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213872
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70200, 70208, 70221, 70242, 70243, 70244]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2019, 7:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 7:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213895
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70264', '70242', '70243', '70244']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2990/mesos-review-70244
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2990/mesos-review-70244/logs/mesos-tests.log):
```
I0321 23:25:52.451818 23624 master.cpp:1295] Agent a9c136cd-584b-49f5-9574-f1954599c2fc-S0 at slave(502)@192.10.1.6:59694 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0321 23:25:52.452865 23624 master.cpp:3330] Disconnecting agent a9c136cd-584b-49f5-9574-f1954599c2fc-S0 at slave(502)@192.10.1.6:59694 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0321 23:25:52.452865 23624 master.cpp:3349] Deactivating agent a9c136cd-584b-49f5-9574-f1954599c2fc-S0 at slave(502)@192.10.1.6:59694 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0321 23:25:52.452865 23084 hierarchical.cpp:391] Removed framework a9c136cd-584b-49f5-9574-f1954599c2fc-0000
I0321 23:25:52.452865 23084 hierarchical.cpp:828] Agent a9c136cd-584b-49f5-9574-f1954599c2fc-S0 deactivated
I0321 23:25:52.453860 23624 containerizer.cpp:2576] Destroying container 5230119f-ea8d-4a8e-90b7-c5e3b74c727e in RUNNING stat[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (690 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (707 ms total)
[----------] Global test environment tear-down
[==========] 1128 tests from 107 test cases ran. (540082 ms total)
[ PASSED ] 1126 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] ContentType/OperationReconciliationTest.FrameworkReconciliationRaceWithUpdateSlaveMessage/0, where GetParam() = application/x-protobuf
[ FAILED ] ContentType/OperationReconciliationTest.FrameworkReconciliationRaceWithUpdateSlaveMessage/1, where GetParam() = application/json
2 FAILED TESTS
YOU HAVE 231 DISABLED TESTS
e
I0321 23:25:52.453860 23624 containerizer.cpp:3278] Transitioning the state of container 5230119f-ea8d-4a8e-90b7-c5e3b74c727e from RUNNING to DESTROYING
I0321 23:25:52.454818 23624 launcher.cpp:161] Asked to destroy container 5230119f-ea8d-4a8e-90b7-c5e3b74c727e
W0321 23:25:52.455790 20672 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=8168 to peer '192.10.1.6:65519': IO failed with error code: The specified network name is no longer available.
W0321 23:25:52.455790 20672 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=7940 to peer '192.10.1.6:65520': IO failed with error code: The specified network name is no longer available.
I0321 23:25:52.542614 17448 containerizer.cpp:3117] Container 5230119f-ea8d-4a8e-90b7-c5e3b74c727e has exited
I0321 23:25:52.572590 26944 master.cpp:1135] Master terminating
I0321 23:25:52.574566 23624 hierarchical.cpp:679] Removed agent a9c136cd-584b-49f5-9574-f1954599c2fc-S0
I0321 23:25:52.983587 20672 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 20, 2019, 7:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 7:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213934
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70264', '70242', '70243', '70244']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2999/mesos-review-70244
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2999/mesos-review-70244/logs/mesos-tests.log):
```
I0322 23:20:34.496538 27168 master.cpp:1295] Agent 30cddddc-b7c6-4b39-b6f2-f167aaa2bc17-S0 at slave(502)@192.10.1.6:61024 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0322 23:20:34.496538 27168 master.cpp:3330] Disconnecting agent 30cddddc-b7c6-4b39-b6f2-f167aaa2bc17-S0 at slave(502)@192.10.1.6:61024 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0322 23:20:34.496538 27168 master.cpp:3349] Deactivating agent 30cddddc-b7c6-4b39-b6f2-f167aaa2bc17-S0 at slave(502)@192.10.1.6:61024 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0322 23:20:34.497529 16232 hierarchical.cpp:391] Removed framework 30cddddc-b7c6-4b39-b6f2-f167aaa2bc17-0000
I0322 23:20:34.497529 25384 containerizer.cpp:2576] Destroying container 7b1c1833-f800-4db2-9c09-e6c86d2ba521 in RUNNING state
I0322 23:20:34.497529 16232 hierarchical.cpp:828] Agent 30cddddc-b7c6-4b39-b6f2-f167aaa2bc17-S0 deactivated
I0322 23:20:34.497529 25384 containerizer.cpp:3278] Transitioning the state of container 7b1c1833-f800-4db2-9c09-e6c86d2ba521 from RUNNING to DESTROYING
I0322 23:20:34.498554 25384 launcher.cpp:161] Asked to destroy container 7b1c1833-f800-4db2-9c09-e6c86d2ba521
W0322 23:20:34.499524 24904 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=9948 to peer '192.10.1.6:50461': IO failed with error code: The specified network name is no longer available.
W0322 23:20:34.499524 24904 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=9312 to peer '192.10.1.6:50462': IO failed with error code: The specified network name is no longer available.
I0322 23:20:34.569519 28152 containerizer.cpp:3117] Container 7b1c1833-f800-4db2-9c09-e6c86d2ba521 has exited
I0322 23:20:34.599589 25384 master.cpp:113[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (687 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (704 ms total)
[----------] Global test environment tear-down
[==========] 1128 tests from 107 test cases ran. (551266 ms total)
[ PASSED ] 1126 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] ContentType/OperationReconciliationTest.FrameworkReconciliationRaceWithUpdateSlaveMessage/0, where GetParam() = application/x-protobuf
[ FAILED ] ContentType/OperationReconciliationTest.FrameworkReconciliationRaceWithUpdateSlaveMessage/1, where GetParam() = application/json
2 FAILED TESTS
YOU HAVE 231 DISABLED TESTS
5] Master terminating
I0322 23:20:34.601016 28376 hierarchical.cpp:679] Removed agent 30cddddc-b7c6-4b39-b6f2-f167aaa2bc17-S0
I0322 23:20:35.032517 24904 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 20, 2019, 12:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 12:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213898
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70264, 70242, 70243, 70244]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2019, 12:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 12:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213852
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70200', '70208', '70221', '70242', '70243', '70244']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2986/mesos-review-70244
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2986/mesos-review-70244/logs/mesos-tests.log):
```
I0320 20:55:31.963344 25524 master.cpp:1295] Agent fe412047-18c4-4610-87df-51f089c4596e-S0 at slave(502)@192.10.1.6:57403 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0320 20:55:31.963344 25524 master.cpp:3330] Disconnecting agent fe412047-18c4-4610-87df-51f089c4596e-S0 at slave(502)@192.10.1.6:57403 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0320 20:55:31.964355 25524 master.cpp:3349] Deactivating agent fe412047-18c4-4610-87df-51f089c4596e-S0 at slave(502)@192.10.1.6:57403 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0320 20:55:31.964355 26132 hierarchical.cpp:391] Removed framework fe412047-18c4-4610-87df-51f089c4596e-0000
I0320 20:55:31.964355 26132 hierarchical.cpp:828] Agent fe412047-18c4-4610-87df-51f089c4596e-S0 deactivated
I0320 20:55:31.965351 25524 containerizer.cpp:2576] Destroying container c8b91113-48e6-43f6-9d3e-e64b83851d40 in RUNNING state
I0320 20:55:31.965351 25524 containerizer.cpp:3278] Transitioning the state of container c8b91113-48e6-43f6-9d3e-e64b83851d40 from RUNNING to DESTROYING
I0320 20:55:31.966377 25524 launcher.cpp:161] Asked to destroy container c8b91113-48e6-43f6-9d3e-e64b83851d40
W0320 20:55:31.967341 21124 process.cpp:1423] Faile[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (668 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (685 ms total)
[----------] Global test environment tear-down
[==========] 1128 tests from 107 test cases ran. (544734 ms total)
[ PASSED ] 1126 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] ContentType/OperationReconciliationTest.FrameworkReconciliationRaceWithUpdateSlaveMessage/0, where GetParam() = application/x-protobuf
[ FAILED ] ContentType/OperationReconciliationTest.FrameworkReconciliationRaceWithUpdateSlaveMessage/1, where GetParam() = application/json
2 FAILED TESTS
YOU HAVE 231 DISABLED TESTS
d to recv on socket WindowsFD::Type::SOCKET=5672 to peer '192.10.1.6:63237': IO failed with error code: The specified network name is no longer available.
W0320 20:55:31.967341 21124 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=10348 to peer '192.10.1.6:63238': IO failed with error code: The specified network name is no longer available.
I0320 20:55:32.043139 26132 containerizer.cpp:3117] Container c8b91113-48e6-43f6-9d3e-e64b83851d40 has exited
I0320 20:55:32.072105 21516 master.cpp:1135] Master terminating
I0320 20:55:32.073105 26132 hierarchical.cpp:679] Removed agent fe412047-18c4-4610-87df-51f089c4596e-S0
I0320 20:55:32.463126 21124 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 20, 2019, 7:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 7:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213932
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70264, 70242, 70243, 70244]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2019, 7:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 7:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213870
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70200', '70208', '70221', '70242', '70243', '70244']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2988/mesos-review-70244
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2988/mesos-review-70244/logs/mesos-tests.log):
```
I0321 00:26:59.199019 22236 master.cpp:1295] Agent f175ca51-a83b-4205-ba4b-08088d6d5ce6-S0 at slave(502)@192.10.1.6:49834 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0321 00:26:59.199019 22236 master.cpp:3330] Disconnecting agent f175ca51-a83b-4205-ba4b-08088d6d5ce6-S0 at slave(502)@192.10.1.6:49834 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0321 00:26:59.200029 22236 master.cpp:3349] Deactivating agent f175ca51-a83b-4205-ba4b-08088d6d5ce6-S0 at slave(502)@192.10.1.6:49834 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0321 00:26:59.200029 27432 hierarchical.cpp:391] Removed framework f175ca51-a83b-4205-ba4b-08088d6d5ce6-0000
I0321 00:26:59.200029 27432 hierarchical.cpp:828] Agent f175ca51-a83b-4205-ba4b-08088d6d5ce6-S0 deactivated
I0321 00:26:59.201032 22236 containerizer.cpp:2576] Destroying container 8bbac391-38d9-4d85-8d10-0170736a7e9c in RUNNING state
I0321 00:2[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (683 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (700 ms total)
[----------] Global test environment tear-down
[==========] 1128 tests from 107 test cases ran. (541020 ms total)
[ PASSED ] 1126 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] ContentType/OperationReconciliationTest.FrameworkReconciliationRaceWithUpdateSlaveMessage/0, where GetParam() = application/x-protobuf
[ FAILED ] ContentType/OperationReconciliationTest.FrameworkReconciliationRaceWithUpdateSlaveMessage/1, where GetParam() = application/json
2 FAILED TESTS
YOU HAVE 231 DISABLED TESTS
6:59.201032 22236 containerizer.cpp:3278] Transitioning the state of container 8bbac391-38d9-4d85-8d10-0170736a7e9c from RUNNING to DESTROYING
I0321 00:26:59.202412 22236 launcher.cpp:161] Asked to destroy container 8bbac391-38d9-4d85-8d10-0170736a7e9c
W0321 00:26:59.203078 22372 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=12780 to peer '192.10.1.6:55703': IO failed with error code: The specified network name is no longer available.
W0321 00:26:59.203078 22372 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=13272 to peer '192.10.1.6:55704': IO failed with error code: The specified network name is no longer available.
I0321 00:26:59.301944 26608 containerizer.cpp:3117] Container 8bbac391-38d9-4d85-8d10-0170736a7e9c has exited
I0321 00:26:59.329967 21024 master.cpp:1135] Master terminating
I0321 00:26:59.330926 5576 hierarchical.cpp:679] Removed agent f175ca51-a83b-4205-ba4b-08088d6d5ce6-S0
I0321 00:26:59.699950 22372 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 20, 2019, 2:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 2:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/
-----------------------------------------------------------
(Updated March 20, 2019, 7:47 p.m.)
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
Bugs: MESOS-9318
https://issues.apache.org/jira/browse/MESOS-9318
Repository: mesos
Description
-------
This patch adds two new operation reconciliation tests,
`OperationOnUnsubscribedProvider` and
`FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
probe scenarios relevant to MESOS-9648 and MESOS-9318.
Diffs (updated)
-----
src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
Diff: https://reviews.apache.org/r/70244/diff/2/
Changes: https://reviews.apache.org/r/70244/diff/1-2/
Testing
-------
`make check`
`bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
`bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Greg Mann <gr...@mesosphere.io>.
> On March 20, 2019, 7:14 p.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 1894 (patched)
> > <https://reviews.apache.org/r/70244/diff/1/?file=2132880#file2132880line1894>
> >
> > Whoops, I intended this to be `OPERATION_FINISHED`. There seems to be an issue....
> >
> > :'(
I forgot to update the resource provider info after the first subscription so that it contains the resource provider ID. Patch updated and all is well.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213845
-----------------------------------------------------------
On March 20, 2019, 7:47 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 7:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213845
-----------------------------------------------------------
src/tests/operation_reconciliation_tests.cpp
Lines 1894 (patched)
<https://reviews.apache.org/r/70244/#comment299944>
Whoops, I intended this to be `OPERATION_FINISHED`. There seems to be an issue....
:'(
- Greg Mann
On March 20, 2019, 2:27 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 2:27 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213817
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70200', '70208', '70221', '70242', '70243', '70244']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2981/mesos-review-70244
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2981/mesos-review-70244/logs/mesos-tests.log):
```
I0320 05:02:50.492841 18368 master.cpp:1295] Agent 8f55158f-940d-452c-b689-41f9bfff514b-S0 at slave(502)@192.10.1.6:62588 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0320 05:02:50.492841 18368 master.cpp:3330] Disconnecting agent 8f55158f-940d-452c-b689-41f9bfff514b-S0 at slave(502)@192.10.1.6:62588 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0320 05:02:50.492841 18368 master.cpp:3349] Deactivating agent 8f55158f-940d-452c-b689-41f9bfff514b-S0 at slave(502)@192.10.1.6:62588 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0320 05:02:50.493786 21456 hierarchical.cpp:391] Removed framework 8f55158f-940d-452c-b689-41f9bfff514b-0000
I0320 05:02:50.493786 21456 hierarchical.cpp:828] Agent 8f55158f-940d-452c-b689-41f9bfff514b-S0 deactivated
I0320 05:02:50.494786 18368 containerizer.cpp:2576] Destroying container 0f7deccd-[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (687 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (705 ms total)
[----------] Global test environment tear-down
[==========] 1128 tests from 107 test cases ran. (513556 ms total)
[ PASSED ] 1126 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] ContentType/OperationReconciliationTest.FrameworkReconciliationRaceWithUpdateSlaveMessage/0, where GetParam() = application/x-protobuf
[ FAILED ] ContentType/OperationReconciliationTest.FrameworkReconciliationRaceWithUpdateSlaveMessage/1, where GetParam() = application/json
2 FAILED TESTS
YOU HAVE 231 DISABLED TESTS
28fd-46e1-aaa8-bd1bcd8add2c in RUNNING state
I0320 05:02:50.494786 18368 containerizer.cpp:3278] Transitioning the state of container 0f7deccd-28fd-46e1-aaa8-bd1bcd8add2c from RUNNING to DESTROYING
I0320 05:02:50.495797 18368 launcher.cpp:161] Asked to destroy container 0f7deccd-28fd-46e1-aaa8-bd1bcd8add2c
W0320 05:02:50.496786 22752 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=6580 to peer '192.10.1.6:64954': IO failed with error code: The specified network name is no longer available.
W0320 05:02:50.496786 22752 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=8120 to peer '192.10.1.6:64955': IO failed with error code: The specified network name is no longer available.
I0320 05:02:50.582593 18548 containerizer.cpp:3117] Container 0f7deccd-28fd-46e1-aaa8-bd1bcd8add2c has exited
I0320 05:02:50.610602 9648 master.cpp:1135] Master terminating
I0320 05:02:50.611609 18548 hierarchical.cpp:679] Removed agent 8f55158f-940d-452c-b689-41f9bfff514b-S0
I0320 05:02:50.968848 22752 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 20, 2019, 2:27 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 2:27 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70244: Added new operation reconciliation tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213821
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70200, 70208, 70221, 70242, 70243, 70244]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2019, 2:27 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 2:27 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-9318
> https://issues.apache.org/jira/browse/MESOS-9318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
>
>
> Diff: https://reviews.apache.org/r/70244/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" --gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>