[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5161: [Refactor][ir] alpha_equal to structural_equal

[GitBox <gi...@apache.org>]

zhiics commented on a change in pull request #5161: [Refactor][ir] alpha_equal to structural_equal
URL: https://github.com/apache/incubator-tvm/pull/5161#discussion_r399695563
 
 

 ##########
 File path: include/tvm/ir/type_relation.h
 ##########
 @@ -203,7 +203,6 @@ class TypeRelationNode : public TypeConstraintNode {
 
   bool SEqualReduce(const TypeRelationNode* other, SEqualReducer equal) const {
     return
-        equal(func, other->func) &&
 
 Review comment:
   @tqchen please check here. I think we shouldn't check `func` here as it is a callback.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services