You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/04 06:16:45 UTC
[GitHub] [apisix-dashboard] xyz2b opened a new issue #1933: On the front end, the websocket button is useless
xyz2b opened a new issue #1933:
URL: https://github.com/apache/apisix-dashboard/issues/1933
## Issue description
<!-- A clear and concise description of what the issue is. -->
I enable websocket in dashborad, but it doesn't work after I saved it.
I check that there is no websocket parameter in the request initiated.
## Expected behavior
<!-- A clear and concise description of what you expected to happen. -->
## How to Reproduce
1. Go to 'route config website'
2. Click on 'WebSocket button'
3. And save route config
4. Checking the configuration of the route
5. The WebSocket button is gray
## Screenshots
<!-- Add screenshots to help explain your problem if applicable. -->
## Environment
* apisix version (cmd: `apisix version`):
* OS (cmd: `uname -a`):
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
* etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
* apisix-dashboard version, if have: 2.6.1
* Browser version, if have: chrome 89.0.4389.90
## Additional context
<!-- Do you want to solve this issue? or add any other context about the problem here. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #1933: On the front end, the websocket button is useless
Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on issue #1933:
URL: https://github.com/apache/apisix-dashboard/issues/1933#issuecomment-894992179
Confirmed, when bind a service in create Route step1, `enable_websocket` will be lost, and without Service binding, `enable_websocket` work normally. Need to fix it in 2.7.1
cc @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1933: On the front end, the websocket button is useless
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1933:
URL: https://github.com/apache/apisix-dashboard/issues/1933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1933: On the front end, the websocket button is useless
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1933:
URL: https://github.com/apache/apisix-dashboard/issues/1933#issuecomment-895017062
@spacewander help request about this `enable_websocket` param in route: when we create a route with `redirect` plugin, does it still need `enable_websocket` param? looking forward to your reply, thanks a lot
after this question got confirmed, I 'll provide corresponding test cases about this issue @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1933: On the front end, the websocket button is useless
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1933:
URL: https://github.com/apache/apisix-dashboard/issues/1933#issuecomment-895078562
> > when we create a route with redirect plugin, does it still need enable_websocket param?
>
> We don't need it.
Thanks a lot @spacewander
then we have to update two points:
1. when we bind service to a Route, we should pass `enable_websocket` normally to API.
this can be tested by recheck `enable_websocket` value in the configure view
2. when we enable `redirect` in a Route, we should omit `enable_websocket` field in the create/configure step1.
this can be tested by
2.1. when we enable `direct`, `enable_websocket` should not exist in the step1
2.2 when we recheck the Route in the configure page, `enable_websocket` still not existed.
@Baoyuantop
cc @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1933: On the front end, the websocket button is useless
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on issue #1933:
URL: https://github.com/apache/apisix-dashboard/issues/1933#issuecomment-854558826
Checking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] spacewander commented on issue #1933: On the front end, the websocket button is useless
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #1933:
URL: https://github.com/apache/apisix-dashboard/issues/1933#issuecomment-895062189
> when we create a route with redirect plugin, does it still need enable_websocket param?
We don't need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1933: On the front end, the websocket button is useless
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1933:
URL: https://github.com/apache/apisix-dashboard/issues/1933#issuecomment-894992179
Confirmed, when bind a service in create Route step1, `enable_websocket` will be lost, and without Service binding, `enable_websocket` work normally. Need to fix it in 2.7.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas removed a comment on issue #1933: On the front end, the websocket button is useless
Posted by GitBox <gi...@apache.org>.
iamayushdas removed a comment on issue #1933:
URL: https://github.com/apache/apisix-dashboard/issues/1933#issuecomment-854558826
Checking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on issue #1933: On the front end, the websocket button is useless
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on issue #1933:
URL: https://github.com/apache/apisix-dashboard/issues/1933#issuecomment-895096746
> > > when we create a route with redirect plugin, does it still need enable_websocket param?
> >
> >
> > We don't need it.
>
> Thanks a lot @spacewander
>
> then we have to update two points:
>
> 1. when we bind service to a Route, we should pass `enable_websocket` normally to API.
> this can be tested by recheck `enable_websocket` value in the configure view
> 2. when we enable `redirect` in a Route, we should omit `enable_websocket` field in the create/configure step1.
> this can be tested by
> 2.1. when we enable `direct`, `enable_websocket` should not exist in the step1
> 2.2 when we recheck the Route in the configure page, `enable_websocket` still not existed.
>
> @Baoyuantop
>
> cc @juzhiyuan
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1933: On the front end, the websocket button is useless
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1933:
URL: https://github.com/apache/apisix-dashboard/issues/1933#issuecomment-895093898
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1933: On the front end, the websocket button is useless
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1933:
URL: https://github.com/apache/apisix-dashboard/issues/1933#issuecomment-894996232
cc @Baoyuantop to take a look, and @liuxiran please provide some necessary testcases for this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org