You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@yetus.apache.org by GitBox <gi...@apache.org> on 2020/10/15 14:33:24 UTC
[GitHub] [yetus] aw-was-here opened a new pull request #160: YETUS-992. Create and publish a github action (more)
aw-was-here opened a new pull request #160:
URL: https://github.com/apache/yetus/pull/160
* use the github action to test the main tree in addition
to the normal testing
* speed up the github action bits in use by caching maven
and fix some related issues with using a pre-built cache
* add documentation about --ignore-unknown-options
* add --report-unknown-options support and docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] ndimiduk commented on a change in pull request #160: YETUS-992. Create and publish a github action (more)
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #160:
URL: https://github.com/apache/yetus/pull/160#discussion_r505875685
##########
File path: start-build-env.sh
##########
@@ -92,14 +92,26 @@ cd "${ROOTDIR}"
# release managers can use the container to do releases
dockerargs=(--rm=true)
-dockerargs+=(-v "${PWD}:/home/${USER_NAME}/yetus${V_OPTS:-}")
dockerargs+=(-w "/home/${USER_NAME}/yetus")
+dockerargs+=(-v "${PWD}:/home/${USER_NAME}/yetus${V_OPTS:-}")
+
+# maven cache
+if [[ ! -d ${HOME}/.m2 ]]; then
+ mkdir "${HOME}/.m2"
+fi
+dockerargs+=(-v "${HOME}/.m2:/home/${USER_NAME}/.m2${V_OPTS:-}")
+
+# GPG Signing for dist creation
+if [[ ! -d ${HOME}/.gnupg ]]; then
+ mkdir "${HOME}/.gnupg"
+fi
+dockerargs+=(-v "${HOME}/.gnupg:/home/${USER_NAME}/.gnupg${V_OPTS:-}")
-if [[ -z ${GITHUB_ACTIONS} ]]; then
- dockerargs+=(-v "${HOME}/.m2:/home/${USER_NAME}/.m2${V_OPTS:-}")
- dockerargs+=(-v "${HOME}/.gnupg:/home/${USER_NAME}/.gnupg")
- dockerargs+=(-v "${HOME}/.ssh:/home/${USER_NAME}/.ssh")
+# git opertions
+if [[ ! -d ${HOME}/.ssh ]]; then
+ mkdir "${HOME}/.ssh"
fi
+dockerargs+=(-v "${HOME}/.ssh:/home/${USER_NAME}/.ssh${V_OPTS:-}")
Review comment:
There's not a better way to pass key materials into the docker process? I'd hope for some solution other than making the private keys visible to the process, something like agent forwarding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #160: YETUS-992. Create and publish a github action (more)
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on pull request #160:
URL: https://github.com/apache/yetus/pull/160#issuecomment-709367565
NOTE: co-dependent on https://github.com/apache/yetus-test-patch-action/pull/4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #160: YETUS-992. Create and publish a github action (more)
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on pull request #160:
URL: https://github.com/apache/yetus/pull/160#issuecomment-709647220
I screwed up the linkchecker tuning. Fixed. Shaved off 6 minutes. Hooray!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #160: YETUS-992. Create and publish a github action (more)
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on pull request #160:
URL: https://github.com/apache/yetus/pull/160#issuecomment-709650058
Thanks for the approval @ndimiduk ! merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here merged pull request #160: YETUS-992. Create and publish a github action (more)
Posted by GitBox <gi...@apache.org>.
aw-was-here merged pull request #160:
URL: https://github.com/apache/yetus/pull/160
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on a change in pull request #160: YETUS-992. Create and publish a github action (more)
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on a change in pull request #160:
URL: https://github.com/apache/yetus/pull/160#discussion_r505927634
##########
File path: start-build-env.sh
##########
@@ -92,14 +92,26 @@ cd "${ROOTDIR}"
# release managers can use the container to do releases
dockerargs=(--rm=true)
-dockerargs+=(-v "${PWD}:/home/${USER_NAME}/yetus${V_OPTS:-}")
dockerargs+=(-w "/home/${USER_NAME}/yetus")
+dockerargs+=(-v "${PWD}:/home/${USER_NAME}/yetus${V_OPTS:-}")
+
+# maven cache
+if [[ ! -d ${HOME}/.m2 ]]; then
+ mkdir "${HOME}/.m2"
+fi
+dockerargs+=(-v "${HOME}/.m2:/home/${USER_NAME}/.m2${V_OPTS:-}")
+
+# GPG Signing for dist creation
+if [[ ! -d ${HOME}/.gnupg ]]; then
+ mkdir "${HOME}/.gnupg"
+fi
+dockerargs+=(-v "${HOME}/.gnupg:/home/${USER_NAME}/.gnupg${V_OPTS:-}")
-if [[ -z ${GITHUB_ACTIONS} ]]; then
- dockerargs+=(-v "${HOME}/.m2:/home/${USER_NAME}/.m2${V_OPTS:-}")
- dockerargs+=(-v "${HOME}/.gnupg:/home/${USER_NAME}/.gnupg")
- dockerargs+=(-v "${HOME}/.ssh:/home/${USER_NAME}/.ssh")
+# git opertions
+if [[ ! -d ${HOME}/.ssh ]]; then
+ mkdir "${HOME}/.ssh"
fi
+dockerargs+=(-v "${HOME}/.ssh:/home/${USER_NAME}/.ssh${V_OPTS:-}")
Review comment:
There are a lot of games one can play with the gpg-agent socket. We should probably look into them now that ssh login into github, etc, are more prevalent. It should be noted that this code is in start-build-env.sh, which up until now was only used for local work. In the GitHub actions case, there are no ssh creds to utilize.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org