You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/29 10:45:22 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7211: drivers/telnet: Remove io work thread
xiaoxiang781216 opened a new pull request, #7211:
URL: https://github.com/apache/incubator-nuttx/pull/7211
## Summary
- drivers/telnet: Return the partial sent bytes in telnet_write
- drivers/telnet: Let psock_poll check the valid of td_psock instead
- drivers/telnet: Remove io work thread
## Impact
telnet driver
## Testing
telnet work as before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #7211: drivers/telnet: Remove io work thread
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #7211:
URL: https://github.com/apache/incubator-nuttx/pull/7211#issuecomment-1262304336
@xiaoxiang781216 please describe in the Summary (or in the log commit) the motivation to remove the work thread.
I saw that CONFIG_TELNET_MAXLCLIENTS was removed in a previous PR, isn't it a good idea to have this limit to avoid DoS attack?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7211: drivers/telnet: Remove io work thread
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7211:
URL: https://github.com/apache/incubator-nuttx/pull/7211#issuecomment-1262406347
> @xiaoxiang781216 please describe in the Summary (or in the log commit) the motivation to remove the work thread.
The motivation is obvious to simplify the flow and reduce the memory. Anyway, I update the commit log.
> I saw that CONFIG_TELNET_MAXLCLIENTS was removed in a previous PR, isn't it a good idea to have this limit to avoid DoS attack?
Before the change, io thread need hold all active clients to talk with the telnet session thread, that's why CONFIG_TELNET_MAXLCLIENTS is defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #7211: drivers/telnet: Remove io work thread
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged PR #7211:
URL: https://github.com/apache/incubator-nuttx/pull/7211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7211: drivers/telnet: Remove io work thread
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7211:
URL: https://github.com/apache/incubator-nuttx/pull/7211#issuecomment-1262486507
@acassis I restore CONFIG_TELNET_MAXLCLIENTS related code, only io thread is removed. Please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org