You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "shoothzj (via GitHub)" <gi...@apache.org> on 2024/01/22 08:58:28 UTC
[PR] [security] Don't print token in heartbeat_server.cpp and Env.java [doris]
shoothzj opened a new pull request, #30227:
URL: https://github.com/apache/doris/pull/30227
Don't print token in heartbeat_server.cpp and Env.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [security] Don't print token in heartbeat_server.cpp and Env.java [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30227:
URL: https://github.com/apache/doris/pull/30227#issuecomment-1905540985
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [security] Don't print token in heartbeat_server.cpp and Env.java [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #30227:
URL: https://github.com/apache/doris/pull/30227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [security] Don't print token in heartbeat_server.cpp and Env.java [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30227:
URL: https://github.com/apache/doris/pull/30227#issuecomment-1904602415
<details>
<summary>TPC-DS: <b>Total hot run time: 176403 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 13a6d0be95176120d74a471db572a68fb1d5886d, data reload: false
query1 929 327 338 327
query2 6564 1969 2001 1969
query3 6703 203 195 195
query4 34557 22220 22251 22220
query5 4453 440 425 425
query6 247 152 154 152
query7 4601 259 265 259
query8 229 179 187 179
query9 8349 2636 2630 2630
query10 417 226 245 226
query11 16816 15575 15507 15507
query12 121 72 68 68
query13 1682 372 381 372
query14 10523 6951 6974 6951
query15 216 187 181 181
query16 5791 267 247 247
query17 938 462 456 456
query18 1787 261 255 255
query19 176 131 139 131
query20 79 65 70 65
query21 183 134 130 130
query22 4849 4863 4745 4745
query23 31437 31050 30888 30888
query24 12578 2769 2836 2769
query25 571 315 311 311
query26 1761 139 144 139
query27 3243 287 283 283
query28 7261 1845 1832 1832
query29 1778 615 631 615
query30 285 137 136 136
query31 941 727 745 727
query32 82 52 48 48
query33 700 209 214 209
query34 1127 450 462 450
query35 870 767 771 767
query36 1359 1118 1239 1118
query37 91 60 65 60
query38 3360 3292 3214 3214
query39 1311 1270 1271 1270
query40 346 96 81 81
query41 38 35 34 34
query42 90 81 81 81
query43 518 479 500 479
query44 1076 708 701 701
query45 187 170 176 170
query46 1069 642 644 642
query47 1654 1572 1565 1565
query48 387 312 318 312
query49 1166 291 283 283
query50 700 319 312 312
query51 5314 5170 5191 5170
query52 85 88 76 76
query53 323 256 257 256
query54 248 173 192 173
query55 85 78 79 78
query56 177 171 170 170
query57 1032 928 930 928
query58 186 160 160 160
query59 2944 2586 2725 2586
query60 206 181 188 181
query61 83 81 82 81
query62 627 354 378 354
query63 292 265 262 262
query64 6136 1781 1748 1748
query65 3342 3275 3214 3214
query66 1210 324 314 314
query67 15766 15107 14925 14925
query68 12481 502 488 488
query69 596 307 292 292
query70 1712 1499 1452 1452
query71 553 217 212 212
query72 4972 2823 2839 2823
query73 2579 318 311 311
query74 7099 6384 6435 6384
query75 5073 2297 2354 2297
query76 6729 1036 1030 1030
query77 668 231 234 231
query78 9069 8917 8520 8520
query79 1013 506 497 497
query80 569 325 318 318
query81 444 207 202 202
query82 201 82 80 80
query83 148 116 123 116
query84 278 69 69 69
query85 1052 343 326 326
query86 391 378 370 370
query87 3541 3349 3317 3317
query88 3188 2194 2187 2187
query89 429 367 346 346
query90 1973 196 188 188
query91 159 131 121 121
query92 53 47 44 44
query93 1345 450 406 406
query94 1236 165 162 162
query95 504 467 456 456
query96 621 316 313 313
query97 4257 4183 4135 4135
query98 212 195 187 187
query99 1025 698 661 661
Total cold run time: 298422 ms
Total hot run time: 176403 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [security] Don't print token in heartbeat_server.cpp and Env.java [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30227:
URL: https://github.com/apache/doris/pull/30227#issuecomment-1904584859
<details>
<summary>TPC-H: <b>Total hot run time: 39391 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 13a6d0be95176120d74a471db572a68fb1d5886d, data reload: false
------ Round 1 ----------------------------------
q1 18497 5367 5348 5348
q2 2055 149 134 134
q3 10753 1187 1182 1182
q4 11697 810 788 788
q5 7779 3197 3152 3152
q6 202 119 118 118
q7 880 501 485 485
q8 9255 1965 1964 1964
q9 8996 6533 6518 6518
q10 8448 3163 3243 3163
q11 432 244 210 210
q12 370 197 201 197
q13 18918 3661 3439 3439
q14 251 224 229 224
q15 567 577 509 509
q16 1051 386 398 386
q17 1220 555 521 521
q18 8080 6915 6711 6711
q19 4313 1369 1340 1340
q20 594 312 317 312
q21 2789 2418 2393 2393
q22 358 312 297 297
Total cold run time: 117505 ms
Total hot run time: 39391 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5514 5424 5221 5221
q2 328 223 213 213
q3 3342 3251 3189 3189
q4 2117 2126 2075 2075
q5 6002 5867 5953 5867
q6 193 119 115 115
q7 2354 1910 1950 1910
q8 3222 3388 3406 3388
q9 9030 8890 8769 8769
q10 3898 3807 3828 3807
q11 560 466 478 466
q12 818 612 626 612
q13 16931 3162 3172 3162
q14 291 256 269 256
q15 543 506 499 499
q16 499 476 468 468
q17 1883 1811 1806 1806
q18 9609 13717 9710 9710
q19 24279 1627 1534 1534
q20 4580 1926 1914 1914
q21 14887 5401 5447 5401
q22 1407 546 563 546
Total cold run time: 112287 ms
Total hot run time: 60928 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [security] Don't print token in heartbeat_server.cpp and Env.java [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30227:
URL: https://github.com/apache/doris/pull/30227#issuecomment-1905541086
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [security] Don't print token in heartbeat_server.cpp and Env.java [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30227:
URL: https://github.com/apache/doris/pull/30227#issuecomment-1903546175
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [security] Don't print token in heartbeat_server.cpp and Env.java [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30227:
URL: https://github.com/apache/doris/pull/30227#issuecomment-1904584306
TeamCity be ut coverage result:
Function Coverage: 36.69% (8663/23610)
Line Coverage: 28.73% (70721/246133)
Region Coverage: 27.61% (36445/131994)
Branch Coverage: 24.34% (18653/76620)
Coverage Report: http://coverage.selectdb-in.cc/coverage/13a6d0be95176120d74a471db572a68fb1d5886d_13a6d0be95176120d74a471db572a68fb1d5886d/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [security] Don't print token in heartbeat_server.cpp and Env.java [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30227:
URL: https://github.com/apache/doris/pull/30227#issuecomment-1904610195
<details>
<summary>ClickBench: <b>Total hot run time: 31.48 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 13a6d0be95176120d74a471db572a68fb1d5886d, data reload: false
query1 0.03 0.03 0.03
query2 0.06 0.02 0.02
query3 0.23 0.05 0.04
query4 1.71 0.06 0.07
query5 0.54 0.53 0.52
query6 1.27 0.64 0.63
query7 0.02 0.01 0.00
query8 0.04 0.02 0.02
query9 0.55 0.52 0.50
query10 0.57 0.56 0.55
query11 0.12 0.08 0.08
query12 0.10 0.09 0.09
query13 0.60 0.61 0.61
query14 0.76 0.84 0.80
query15 0.79 0.78 0.78
query16 0.37 0.39 0.39
query17 0.98 1.01 1.03
query18 0.24 0.24 0.26
query19 1.87 1.79 1.82
query20 0.01 0.01 0.01
query21 15.42 0.58 0.57
query22 2.38 2.78 1.97
query23 17.43 0.84 0.74
query24 2.41 1.27 1.22
query25 0.44 0.20 0.26
query26 0.45 0.14 0.14
query27 0.06 0.04 0.05
query28 10.99 0.77 0.78
query29 12.54 3.30 3.22
query30 0.52 0.49 0.53
query31 2.78 0.36 0.35
query32 3.37 0.47 0.48
query33 3.20 3.26 3.25
query34 16.01 4.25 4.33
query35 4.35 4.30 4.31
query36 1.13 1.08 1.07
query37 0.06 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.02 0.01
query40 0.16 0.13 0.13
query41 0.08 0.01 0.01
query42 0.03 0.01 0.02
query43 0.03 0.02 0.02
Total cold run time: 104.76 s
Total hot run time: 31.48 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [security] Don't print token in heartbeat_server.cpp and Env.java [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30227:
URL: https://github.com/apache/doris/pull/30227#issuecomment-1904615765
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 13a6d0be95176120d74a471db572a68fb1d5886d with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 15.0 seconds inserted 10000000 Rows, about 666K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [security] Don't print token in heartbeat_server.cpp and Env.java [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #30227:
URL: https://github.com/apache/doris/pull/30227#issuecomment-1904525604
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org