You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by is...@apache.org on 2017/01/21 23:53:39 UTC
[3/3] lucene-solr:jira/solr-5944: SOLR-5944: Removing nocommit
requesting additional review. We've already synchronized the entire method,
which should be safer than before
SOLR-5944: Removing nocommit requesting additional review. We've already synchronized the entire method, which should be safer than before
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/5fc87843
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/5fc87843
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/5fc87843
Branch: refs/heads/jira/solr-5944
Commit: 5fc87843dc8e8bc8f954f40c6eafb7ce0aa73b80
Parents: 1aaa03d
Author: Ishan Chattopadhyaya <is...@apache.org>
Authored: Sun Jan 22 05:23:20 2017 +0530
Committer: Ishan Chattopadhyaya <is...@apache.org>
Committed: Sun Jan 22 05:23:20 2017 +0530
----------------------------------------------------------------------
solr/core/src/java/org/apache/solr/update/UpdateLog.java | 2 --
1 file changed, 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/5fc87843/solr/core/src/java/org/apache/solr/update/UpdateLog.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/update/UpdateLog.java b/solr/core/src/java/org/apache/solr/update/UpdateLog.java
index 23a7670..aaa6b6a 100644
--- a/solr/core/src/java/org/apache/solr/update/UpdateLog.java
+++ b/solr/core/src/java/org/apache/solr/update/UpdateLog.java
@@ -843,8 +843,6 @@ public static final int VERSION_IDX = 1;
synchronized public long applyPartialUpdates(BytesRef id, long prevPointer, long prevVersion,
Set<String> onlyTheseFields, SolrDocumentBase latestPartialDoc) {
- // nocommit: need additional eyeballs (besides ishan & hoss) on the synchronization in this method/class
-
SolrInputDocument partialUpdateDoc = null;
List<TransactionLog> lookupLogs = Arrays.asList(tlog, prevMapLog, prevMapLog2);