You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/07 05:55:07 UTC

[GitHub] [spark] Eric5553 opened a new pull request #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Eric5553 opened a new pull request #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846
 
 
   ### What changes were proposed in this pull request?
   RuleExecutor already support metering for analyzer/optimizer rules. By providing such information in Explain command, user can get better interactive user experience when debugging a specific query.
   This PR enhanced `EXPLAIN FORMATTED` to display RuleExecutor metrics. This can be easily done by calling the existing API `resetMetrics` and `dumpTimeSpent`, but there might be conflicts if user collect total metrics of a sql job which includes some explain commands. Thus I introduced `QueryExecutionMetrics`, as the snapshot of `QueryExecutionMetering`, to better support this feature.
   
   Information added to `Explain Formatted`
   ```
   === Metrics of Analyzer/Optimizer Rules ===
   Total number of runs: 554
   Total time: 0.107756568 seconds
   Total number of effective runs: 11
   Total time of effective runs: 0.047615486 seconds
   ```
   
   
   ### Why are the changes needed?
   Provide better query debugging user experience
   
   
   ### Does this PR introduce any user-facing change?
   Add  RuleExecutor metrics in Explain Formatted
   
   
   ### How was this patch tested?
   Update existing tests
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596567245
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119564/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596566052
 
 
   **[Test build #119564 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119564/testReport)** for PR 27846 at commit [`abc864e`](https://github.com/apache/spark/commit/abc864ef7e41d65932060436331a57db8d77fbe7).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596059713
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119509/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#discussion_r389412704
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
 ##########
 @@ -231,7 +238,7 @@ abstract class RuleExecutor[TreeType <: TreeNode[_]] extends Logging {
             s"""
                |=== Result of Batch ${batchName} ===
                |${sideBySide(oldPlan.treeString, newPlan.treeString).mkString("\n")}
-          """.stripMargin
+            """.stripMargin
 
 Review comment:
   unnecessary change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596531877
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596516590
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596060130
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24239/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596060020
 
 
   **[Test build #119510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119510/testReport)** for PR 27846 at commit [`ce0bedb`](https://github.com/apache/spark/commit/ce0bedb30ac21c5fe133526dce1dce0472c8f494).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596059705
 
 
   **[Test build #119509 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119509/testReport)** for PR 27846 at commit [`ce0bedb`](https://github.com/apache/spark/commit/ce0bedb30ac21c5fe133526dce1dce0472c8f494).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596531877
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596668922
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596057387
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596221924
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24269/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596221733
 
 
   **[Test build #119537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119537/testReport)** for PR 27846 at commit [`42e40d2`](https://github.com/apache/spark/commit/42e40d2d3951ffbb06b636a5b4d5fd2801485544).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu edited a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
maropu edited a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596154086
 
 
   Are these metrics benefit for general users? If these metrics are for developers, how about just showing these metrics via a logger with `spark.sql.optimizer.planChangeLog.level`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596057387
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596667855
 
 
   **[Test build #119567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119567/testReport)** for PR 27846 at commit [`36bf2e1`](https://github.com/apache/spark/commit/36bf2e134436a9b5c7d96c839855dd69cef45538).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596221920
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596531889
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119561/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596051261
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24235/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596417538
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24292/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596221733
 
 
   **[Test build #119537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119537/testReport)** for PR 27846 at commit [`42e40d2`](https://github.com/apache/spark/commit/42e40d2d3951ffbb06b636a5b4d5fd2801485544).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Eric5553 commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#discussion_r389543359
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerLoggingSuite.scala
 ##########
 @@ -49,12 +49,19 @@ class OptimizerLoggingSuite extends PlanTest {
       case event => Seq(
         "Applying Rule",
         "Result of Batch",
-        "has no effect").exists(event.getRenderedMessage().contains)
+        "has no effect",
+        "Metrics of Executed Rules").exists(event.getRenderedMessage().contains)
 
 Review comment:
   The metrics will be reported at `RuleExecutor.execute` level. I double checked the code and found I logged it at the wrong place within `batches.foreach` loop.  Fixed it by abc864ef7e41d65932060436331a57db8d77fbe7.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596567233
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596516590
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596154086
 
 
   Are these metrics benefit for general users? If these metrics are for developers, how about just showing these metrics via `spark.sql.optimizer.planChangeLog.level`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596051259
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596435063
 
 
   **[Test build #119564 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119564/testReport)** for PR 27846 at commit [`abc864e`](https://github.com/apache/spark/commit/abc864ef7e41d65932060436331a57db8d77fbe7).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596435738
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596417530
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596081692
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596051259
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596247341
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Eric5553 commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
Eric5553 commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596059892
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-597362466
 
 
   late LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596057389
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24238/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#discussion_r389520742
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerLoggingSuite.scala
 ##########
 @@ -49,12 +49,19 @@ class OptimizerLoggingSuite extends PlanTest {
       case event => Seq(
         "Applying Rule",
         "Result of Batch",
-        "has no effect").exists(event.getRenderedMessage().contains)
+        "has no effect",
+        "Metrics of Executed Rules").exists(event.getRenderedMessage().contains)
 
 Review comment:
   this only exists if `Result of Batch` exists?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596081553
 
 
   **[Test build #119510 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119510/testReport)** for PR 27846 at commit [`ce0bedb`](https://github.com/apache/spark/commit/ce0bedb30ac21c5fe133526dce1dce0472c8f494).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596221010
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24268/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596531889
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119561/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Eric5553 commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#discussion_r389543359
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerLoggingSuite.scala
 ##########
 @@ -49,12 +49,19 @@ class OptimizerLoggingSuite extends PlanTest {
       case event => Seq(
         "Applying Rule",
         "Result of Batch",
-        "has no effect").exists(event.getRenderedMessage().contains)
+        "has no effect",
+        "Metrics of Executed Rules").exists(event.getRenderedMessage().contains)
 
 Review comment:
   The metrics will be reported for each `RuleExecutor.execute` call. I double checked the code and found I logged it at the wrong place within `batches.foreach` loop.  Fixed it by abc864ef7e41d65932060436331a57db8d77fbe7.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596081692
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596417530
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596060129
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#discussion_r389583140
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/QueryExecutionMetering.scala
 ##########
 @@ -95,3 +107,26 @@ case class QueryExecutionMetering() {
      """.stripMargin
   }
 }
+
+case class QueryExecutionMetrics(
+    time: Long,
+    numRuns: Long,
+    numEffectiveRuns: Long,
+    timeEffective: Long) {
+
+  def +(metrics: QueryExecutionMetrics): QueryExecutionMetrics = {
 
 Review comment:
   is this method needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596247103
 
 
   **[Test build #119537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119537/testReport)** for PR 27846 at commit [`42e40d2`](https://github.com/apache/spark/commit/42e40d2d3951ffbb06b636a5b4d5fd2801485544).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596435750
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24295/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596247341
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596055656
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119506/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Eric5553 commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#discussion_r389647740
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/QueryExecutionMetering.scala
 ##########
 @@ -95,3 +107,26 @@ case class QueryExecutionMetering() {
      """.stripMargin
   }
 }
+
+case class QueryExecutionMetrics(
+    time: Long,
+    numRuns: Long,
+    numEffectiveRuns: Long,
+    timeEffective: Long) {
+
+  def +(metrics: QueryExecutionMetrics): QueryExecutionMetrics = {
 
 Review comment:
   Emm. Not used by now, agree to add it once we really need this. Removed in 36bf2e134436a9b5c7d96c839855dd69cef45538.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596514900
 
 
   **[Test build #119567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119567/testReport)** for PR 27846 at commit [`36bf2e1`](https://github.com/apache/spark/commit/36bf2e134436a9b5c7d96c839855dd69cef45538).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596435750
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24295/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596060020
 
 
   **[Test build #119510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119510/testReport)** for PR 27846 at commit [`ce0bedb`](https://github.com/apache/spark/commit/ce0bedb30ac21c5fe133526dce1dce0472c8f494).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596057274
 
 
   **[Test build #119509 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119509/testReport)** for PR 27846 at commit [`ce0bedb`](https://github.com/apache/spark/commit/ce0bedb30ac21c5fe133526dce1dce0472c8f494).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596247344
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119537/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596081696
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119510/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596668945
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119567/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596247344
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119537/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596516606
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24298/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596435063
 
 
   **[Test build #119564 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119564/testReport)** for PR 27846 at commit [`abc864e`](https://github.com/apache/spark/commit/abc864ef7e41d65932060436331a57db8d77fbe7).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Eric5553 commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#discussion_r389434541
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
 ##########
 @@ -231,7 +238,7 @@ abstract class RuleExecutor[TreeType <: TreeNode[_]] extends Logging {
             s"""
                |=== Result of Batch ${batchName} ===
                |${sideBySide(oldPlan.treeString, newPlan.treeString).mkString("\n")}
-          """.stripMargin
+            """.stripMargin
 
 Review comment:
   I thought the padding was incorrect, so fixed it here together.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Eric5553 commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
Eric5553 commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#discussion_r389434541
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
 ##########
 @@ -231,7 +238,7 @@ abstract class RuleExecutor[TreeType <: TreeNode[_]] extends Logging {
             s"""
                |=== Result of Batch ${batchName} ===
                |${sideBySide(oldPlan.treeString, newPlan.treeString).mkString("\n")}
-          """.stripMargin
+            """.stripMargin
 
 Review comment:
   I thought the ident here was incorrect, so fixed it together.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Eric5553 commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
Eric5553 commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596208785
 
 
   > Are these metrics benefit for general users? If these metrics are for developers, how about just showing these metrics via a logger with `spark.sql.optimizer.planChangeLog.level`?
   
   Yea, logging message should be enough. I'll make the change, thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596358727
 
 
   The improvement looks fine to me.  WDYT? @maryannxue @cloud-fan 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596221924
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24269/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596668945
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119567/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596051169
 
 
   **[Test build #119506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119506/testReport)** for PR 27846 at commit [`d0e421f`](https://github.com/apache/spark/commit/d0e421f2940ccb0014912e75460ca0da67926b06).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596060130
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24239/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596055656
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119506/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596567233
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596567245
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119564/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596221010
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24268/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596221007
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596417538
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24292/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596055652
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596417058
 
 
   **[Test build #119561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119561/testReport)** for PR 27846 at commit [`abc864e`](https://github.com/apache/spark/commit/abc864ef7e41d65932060436331a57db8d77fbe7).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596057274
 
 
   **[Test build #119509 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119509/testReport)** for PR 27846 at commit [`ce0bedb`](https://github.com/apache/spark/commit/ce0bedb30ac21c5fe133526dce1dce0472c8f494).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-597023610
 
 
   thanks, merging to master/3.0!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596059712
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596221007
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596516606
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24298/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Eric5553 commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
Eric5553 commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-597118910
 
 
   @cloud-fan @maropu Thanks so much!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Eric5553 commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
Eric5553 commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596432139
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596055641
 
 
   **[Test build #119506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119506/testReport)** for PR 27846 at commit [`d0e421f`](https://github.com/apache/spark/commit/d0e421f2940ccb0014912e75460ca0da67926b06).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `case class QueryExecutionMetrics(`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596051169
 
 
   **[Test build #119506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119506/testReport)** for PR 27846 at commit [`d0e421f`](https://github.com/apache/spark/commit/d0e421f2940ccb0014912e75460ca0da67926b06).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596051261
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24235/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596059713
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119509/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596057389
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24238/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596530877
 
 
   **[Test build #119561 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119561/testReport)** for PR 27846 at commit [`abc864e`](https://github.com/apache/spark/commit/abc864ef7e41d65932060436331a57db8d77fbe7).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596059712
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596081696
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119510/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#discussion_r389485179
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
 ##########
 @@ -231,7 +238,7 @@ abstract class RuleExecutor[TreeType <: TreeNode[_]] extends Logging {
             s"""
                |=== Result of Batch ${batchName} ===
                |${sideBySide(oldPlan.treeString, newPlan.treeString).mkString("\n")}
-          """.stripMargin
+            """.stripMargin
 
 Review comment:
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596435738
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596055652
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Add RuleExecutor metrics in Explain Formatted
URL: https://github.com/apache/spark/pull/27846#issuecomment-596060129
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596417058
 
 
   **[Test build #119561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119561/testReport)** for PR 27846 at commit [`abc864e`](https://github.com/apache/spark/commit/abc864ef7e41d65932060436331a57db8d77fbe7).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596668922
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596221920
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27846: [SPARK-31079][SQL] Logging QueryExecutionMetering in RuleExecutor logger
URL: https://github.com/apache/spark/pull/27846#issuecomment-596514900
 
 
   **[Test build #119567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119567/testReport)** for PR 27846 at commit [`36bf2e1`](https://github.com/apache/spark/commit/36bf2e134436a9b5c7d96c839855dd69cef45538).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org