[GitHub] [solr] dsmiley commented on a diff in pull request #1031: SOLR-16422: Upgrade Apache Zookeeper to 3.8.0

[GitBox <gi...@apache.org>]

dsmiley commented on code in PR #1031:
URL: https://github.com/apache/solr/pull/1031#discussion_r975883493


##########
gradle/hacks/global-exclude-dependencies.gradle:
##########
@@ -40,6 +40,7 @@ allprojects { prj ->
   ]
   configurations.matching { it.name in configNames }.all {
     exclude group: 'log4j', module: 'log4j' // use SLF4j
+    exclude group: "ch.qos.logback" // use SLF4j
     exclude group: 'commons-logging', module: 'commons-logging' // use SLF4j
     exclude group: 'com.google.code.findbugs', module: 'jsr305' // Uses GPL license
     exclude group: 'com.google.code.findbugs', module: 'annotations' // Use Spotbugs Annotations as replacement

Review Comment:
   Just FYI (not specific to this PR), if you look at our generated POMs, you will see that each dependency has an excludes list of the list above.  This is even if what's excluded isn't even a transitive dependency to where it's attached.  Our system works but it's annoyingly verbose.



##########
versions.lock:
##########
@@ -268,11 +273,15 @@ org.glassfish.jersey.inject:jersey-hk2:2.35 (1 constraints: de04fe30)
 org.glassfish.jersey.media:jersey-media-json-jackson:2.35 (1 constraints: de04fe30)
 org.hamcrest:hamcrest:2.2 (3 constraints: 7620ce25)
 org.hamcrest:hamcrest-core:2.2 (1 constraints: cc05fe3f)
+org.immutables:value-annotations:2.9.2 (1 constraints: 0f051236)
 org.itadaki:bzip2:0.9.1 (2 constraints: bd0c4b2c)
 org.javassist:javassist:3.25.0-GA (1 constraints: 2a110ef1)
 org.jctools:jctools-core:3.3.0 (1 constraints: 08050336)
 org.jdom:jdom2:2.0.6.1 (1 constraints: be0c371b)
 org.junit:junit-bom:5.9.0 (1 constraints: c7116dde)
+org.locationtech.jts:jts-core:1.19.0 (2 constraints: a31de760)

Review Comment:
   Woah; we're adding a dependency on JTS?  Okay; there's a Solr JIRA that debates doing this for Solr-core.
   I wonder if it's actually used, though?  Like is this for features that a Calcite/Solr user is unlikely to use?  I'm not sure honestly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org