You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by "Andrew Kyle Purtell (Jira)" <ji...@apache.org> on 2022/06/16 01:24:00 UTC

[jira] [Resolved] (HBASE-7888) Simplify logic of SnapshotManager#getCompletedSnapshots()

     [ https://issues.apache.org/jira/browse/HBASE-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kyle Purtell resolved HBASE-7888.
----------------------------------------
    Resolution: Invalid

> Simplify logic of SnapshotManager#getCompletedSnapshots()
> ---------------------------------------------------------
>
>                 Key: HBASE-7888
>                 URL: https://issues.apache.org/jira/browse/HBASE-7888
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Priority: Major
>
> This came up during code review of mega patch.
> isSnapshotCompleted() checks the existence of snapshotDir to see if the snapshot already exists.
> getCompletedSnapshots(), on the other hand, reads SnapshotDescriptionUtils.SNAPSHOTINFO_FILE for the same purpose.
> Since all the snapshot files are first created in a tmp dir and a rename is done to move them into the .snapshots dir upon completion, logic in getCompletedSnapshots() can be simplified.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)