You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/08/10 00:23:46 UTC
[PR] Restore the table borders lost in the APT conversion [maven-surefire]
slachiewicz opened a new pull request, #3424:
URL: https://github.com/apache/maven-surefire/pull/3424
Follow-up to #3422, which merged before this fix could be included.
## The problem
A Markdown pipe table renders as `class="table table-striped"`. The APT tables these two pages came from rendered as `class="table table-bordered table-striped"`, so the conversion quietly dropped the cell borders on:
* `maven-surefire-plugin/src/site/markdown/examples/toolchains.md.vm`
* `surefire-api/src/site/markdown/index.md`
I reported this in #3422 as a limitation of the Markdown sink that could not be controlled from the source document. **That was wrong** — it is true of a pipe table, but not of the source in general.
## The fix
Doxia parses a raw HTML `<table>` back into the same table it built from APT: the class and the per-cell `style` survive verbatim, and it still applies the alternating `tr class="a"`/`"b"` itself. Writing these two tables out as HTML restores the original rendering exactly.
## Verification
Compared against the pre-conversion site, on the same three axes used for #3422 — document title, author and date metadata plus visible text and link targets; block structure including `<pre>` and `<table>` classes; and heading anchors:
* **`examples/toolchains.html`** drops out of **all three** axes entirely. It is now an exact match for the APT baseline, `table-bordered` and `style="text-align: left;"` and all.
* **`surefire-api/index.html`**'s only remaining difference is the two `Term`/`Definition` header cells, which were added deliberately in #3422 because a Markdown table cannot express a headerless one.
## What is deliberately left alone
`maven-surefire-plugin/src/site/markdown/history.md.vm` keeps its Markdown table. It carries 24 links and 38 line breaks across nine rows, and it is the changelog that gains a row every release — handing maintainers hand-written HTML in the file they edit most often, to gain a border, is the wrong trade. That page keeps `table table-striped`.
Generated-by: Claude Opus 5 (1M context)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore the table borders lost in the APT conversion [maven-surefire]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #3424:
URL: https://github.com/apache/maven-surefire/pull/3424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org