[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

["Bankim Bhavsar (Code Review)" <ge...@cloudera.org>]

Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 )

Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15034/11/src/kudu/common/wire_protocol.cc
File src/kudu/common/wire_protocol.cc:

http://gerrit.cloudera.org:8080/#/c/15034/11/src/kudu/common/wire_protocol.cc@623
PS11, Line 623:       auto allocator = arena->NewObject<ArenaBlockBloomFilterBufferAllocator>(arena);
> Looking at the code again, I'm a little confused as to how this works, beca
"allocator" is allocated in the arena like on heap and isn't deleted on exiting the scope.

So the "allocator" like the bloom filters allocated in the arena will be valid till the arena is destructed.



-- 
To view, visit http://gerrit.cloudera.org:8080/15034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ecfd67e9c5fbe459c5b4aed91e0be2a194d433a
Gerrit-Change-Number: 15034
Gerrit-PatchSet: 11
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 18:29:16 +0000
Gerrit-HasComments: Yes