You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/03/11 15:03:27 UTC
Review Request 70183: Made setting volume ownership asynchronous.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70183/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9643
https://issues.apache.org/jira/browse/MESOS-9643
Repository: mesos
Description
-------
Setting volume ownership can be expensive because we need to traverse
all the directories and files in it. So in this patch we make setting
volume ownership asynchronous which will improve the performance in
the following cases:
1. Launching a container which uses two difererent volumes.
2. Launching two containers simultaneously which use two different
volumes respectively.
3. Launching a container which uses a volume while another task which
uses a volume is being destroyed, and vice versa.
Diffs
-----
src/slave/volume_gid_manager/volume_gid_manager.cpp c0fc1db24760e691214de991529f8963faf597f4
Diff: https://reviews.apache.org/r/70183/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 70183: Made setting volume ownership asynchronous.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70183/#review213617
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 11, 2019, 8:03 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70183/
> -----------------------------------------------------------
>
> (Updated March 11, 2019, 8:03 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9643
> https://issues.apache.org/jira/browse/MESOS-9643
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Setting volume ownership can be expensive because we need to traverse
> all the directories and files in it. So in this patch we make setting
> volume ownership asynchronous which will improve the performance in
> the following cases:
> 1. Launching a container which uses two difererent volumes.
> 2. Launching two containers simultaneously which use two different
> volumes respectively.
> 3. Launching a container which uses a volume while another task which
> uses a volume is being destroyed, and vice versa.
>
>
> Diffs
> -----
>
> src/slave/volume_gid_manager/volume_gid_manager.cpp c0fc1db24760e691214de991529f8963faf597f4
>
>
> Diff: https://reviews.apache.org/r/70183/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70183: Made setting volume ownership asynchronous.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70183/#review213596
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70183]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 11, 2019, 3:03 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70183/
> -----------------------------------------------------------
>
> (Updated March 11, 2019, 3:03 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9643
> https://issues.apache.org/jira/browse/MESOS-9643
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Setting volume ownership can be expensive because we need to traverse
> all the directories and files in it. So in this patch we make setting
> volume ownership asynchronous which will improve the performance in
> the following cases:
> 1. Launching a container which uses two difererent volumes.
> 2. Launching two containers simultaneously which use two different
> volumes respectively.
> 3. Launching a container which uses a volume while another task which
> uses a volume is being destroyed, and vice versa.
>
>
> Diffs
> -----
>
> src/slave/volume_gid_manager/volume_gid_manager.cpp c0fc1db24760e691214de991529f8963faf597f4
>
>
> Diff: https://reviews.apache.org/r/70183/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>