You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/21 13:51:45 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #13676: ARROW-17107: [Java] Fix variable-width vectors in integration JSON writer
lidavidm opened a new pull request, #13676:
URL: https://github.com/apache/arrow/pull/13676
- Clarify that this is meant to be an internal format
- Fix handling of empty variable-width vectors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #13676: ARROW-17107: [Java] Fix variable-width vectors in integration JSON writer
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #13676:
URL: https://github.com/apache/arrow/pull/13676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13676: ARROW-17107: [Java] Fix variable-width vectors in integration JSON writer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13676:
URL: https://github.com/apache/arrow/pull/13676#issuecomment-1191729241
https://issues.apache.org/jira/browse/ARROW-17107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13676: ARROW-17107: [Java] Fix variable-width vectors in integration JSON writer
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13676:
URL: https://github.com/apache/arrow/pull/13676#issuecomment-1194029803
Benchmark runs are scheduled for baseline = d584b8d7a1c1a4ee1a658bcf9cde9f3a85ae172b and contender = c2eda76eb84f5bb8c7272b4c2b0cd6be05c06517. c2eda76eb84f5bb8c7272b4c2b0cd6be05c06517 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/efcb201c31634817a455dfe78fb7fe86...36a459c1ef984ed59bdfdd90c36b1cdb/)
[Failed :arrow_down:0.44% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ddf5d00c33f841a790b3a46220e7be62...93ff15704f0549098ab57131b030e7d2/)
[Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c5f4409f7563471cb5723075afc83320...a375ee2bbad640938e1ebe2f234283dd/)
[Finished :arrow_down:0.29% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f5bd0f7fd4e54b61bd8c82118f0686fa...dfc8efb5ee7a42a6b1e2fd115b7d5bbd/)
Buildkite builds:
[Failed] [`c2eda76e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1192)
[Failed] [`c2eda76e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1204)
[Failed] [`c2eda76e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1186)
[Finished] [`c2eda76e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1206)
[Failed] [`d584b8d7` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1191)
[Failed] [`d584b8d7` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1203)
[Finished] [`d584b8d7` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1185)
[Finished] [`d584b8d7` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1205)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jarohen commented on pull request #13676: ARROW-17107: [Java] Fix variable-width vectors in integration JSON writer
Posted by GitBox <gi...@apache.org>.
jarohen commented on PR #13676:
URL: https://github.com/apache/arrow/pull/13676#issuecomment-1193955441
Thanks @lidavidm & @lwhite1! :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13676: ARROW-17107: [Java] Fix variable-width vectors in integration JSON writer
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13676:
URL: https://github.com/apache/arrow/pull/13676#discussion_r926929036
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileWriter.java:
##########
@@ -83,8 +84,10 @@
import com.fasterxml.jackson.databind.MappingJsonFactory;
/**
- * A writer that converts binary Vectors into a JSON format suitable
+ * A writer that converts binary Vectors into an <em>internal, unstable</em> JSON format suitable
Review Comment:
Integration tests are run via a binary, not via JUnit, so they need to end up in something that gets compiled into a JAR. (Also I'd be a little hesitant to break compatibility immediately here.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lwhite1 commented on a diff in pull request #13676: ARROW-17107: [Java] Fix variable-width vectors in integration JSON writer
Posted by GitBox <gi...@apache.org>.
lwhite1 commented on code in PR #13676:
URL: https://github.com/apache/arrow/pull/13676#discussion_r926918365
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileWriter.java:
##########
@@ -83,8 +84,10 @@
import com.fasterxml.jackson.databind.MappingJsonFactory;
/**
- * A writer that converts binary Vectors into a JSON format suitable
+ * A writer that converts binary Vectors into an <em>internal, unstable</em> JSON format suitable
Review Comment:
If this is intended for integration testing, could it be under the test directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lwhite1 commented on pull request #13676: ARROW-17107: [Java] Fix variable-width vectors in integration JSON writer
Posted by GitBox <gi...@apache.org>.
lwhite1 commented on PR #13676:
URL: https://github.com/apache/arrow/pull/13676#issuecomment-1191959729
Makes perfect sense. Thanks
On Thu, Jul 21, 2022 at 1:20 PM David Li ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In
> java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileWriter.java
> <https://github.com/apache/arrow/pull/13676#discussion_r926929036>:
>
> > @@ -83,8 +84,10 @@
> import com.fasterxml.jackson.databind.MappingJsonFactory;
>
> /**
> - * A writer that converts binary Vectors into a JSON format suitable
> + * A writer that converts binary Vectors into an <em>internal, unstable</em> JSON format suitable
>
> Integration tests are run via a binary, not via JUnit, so they need to end
> up in something that gets compiled into a JAR. (Also I'd be a little
> hesitant to break compatibility immediately here.)
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/arrow/pull/13676#discussion_r926929036>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AA2FPAXB467MABONC7CGBW3VVGBFHANCNFSM54HXGXTA>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org