You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by gvramana <gi...@git.apache.org> on 2018/07/04 14:52:31 UTC

[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2420#discussion_r200150569
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java ---
    @@ -345,14 +346,18 @@ public static CarbonLoadModel getLoadModel(Configuration conf) throws IOExceptio
                         CarbonCommonConstants.LOAD_BATCH_SORT_SIZE_INMB,
                         CarbonCommonConstants.LOAD_BATCH_SORT_SIZE_INMB_DEFAULT))));
     
    -    model.setBadRecordsLocation(
    -        conf.get(BAD_RECORD_PATH,
    -            carbonProperty.getProperty(
    -                CarbonLoadOptionConstants.CARBON_OPTIONS_BAD_RECORD_PATH,
    -                carbonProperty.getProperty(
    -                    CarbonCommonConstants.CARBON_BADRECORDS_LOC,
    -                    CarbonCommonConstants.CARBON_BADRECORDS_LOC_DEFAULT_VAL))));
    -
    +    String badRecordsPath = conf.get(BAD_RECORD_PATH);
    +    if (StringUtils.isEmpty(badRecordsPath)) {
    +      badRecordsPath =
    --- End diff --
    
    carbon table properties should be checked first then take from configuration


---