You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2017/12/21 22:19:42 UTC

[GitHub] d3zd3z commented on a change in pull request #119: Fix pbkdf2 hash

d3zd3z commented on a change in pull request #119: Fix pbkdf2 hash
URL: https://github.com/apache/mynewt-newt/pull/119#discussion_r158391357
 
 

 ##########
 File path: newt/image/encrypted.go
 ##########
 @@ -147,39 +147,9 @@ func unwrapPbes2Pbkdf2(param *pbkdf2Param, size int, iv []byte, hashNew hashFunc
 	plain := make([]byte, len(encrypted))
 	enc.CryptBlocks(plain, encrypted)
 
-	plain, err = checkPkcs7Padding(plain)
 
 Review comment:
   It "works", but it then doesn't detect messages with corrupt padding. We really do need to verify that padding after performing the decryption.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services