You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/04 16:24:46 UTC
[GitHub] [shardingsphere] Swastyy opened a new pull request #11651: Move change history in java api to others
Swastyy opened a new pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651
Fixes #10976
Changes proposed in this pull request:
- Created java-api folder in sharding-sphere-jdbc
- Moved `change-history.en.md`
- Changes in `change-history.en.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-893561897
@tristaZero @RaigorJiang @menghaoranss Pl review this PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-894642601
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11651](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e033ab6) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6972cf8fb26a9393d7f6a8386fd74e0917cdaeee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6972cf8) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head e033ab6 differs from pull request most recent head b84a083. Consider uploading reports for the commit b84a083 to get more accurate results
[](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11651 +/- ##
=========================================
Coverage 63.66% 63.66%
Complexity 1122 1122
=========================================
Files 2269 2269
Lines 34632 34632
Branches 6029 6029
=========================================
Hits 22049 22049
Misses 10819 10819
Partials 1764 1764
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6972cf8...b84a083](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-894642601
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11651](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b84a083) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6972cf8fb26a9393d7f6a8386fd74e0917cdaeee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6972cf8) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11651 +/- ##
=========================================
Coverage 63.66% 63.66%
Complexity 1122 1122
=========================================
Files 2269 2269
Lines 34632 34632
Branches 6029 6029
=========================================
Hits 22049 22049
Misses 10819 10819
Partials 1764 1764
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6972cf8...b84a083](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-893956875
@Swastyy
Thanks for your update, but I have some questions:
1. Why are there both `Readwrite-splitting` and `Replica Query` in `5.0.0-beta`, they actually have the same meaning, the current name is `Readwrite-splitting`. So please remove `Replica Query`.
2. The following configuration informations are missing in 5.0.0-beta:
- Sharding Table Configuration, Sharding Automatic Table Configuration, Sharding Strategy Configuration (in [Sharding](https://github.com/apache/shardingsphere/blob/master/docs/document/content/user-manual/shardingsphere-jdbc/configuration/java-api/sharding.en.md)
- Root Configuration (in [Readwrite-splitting](https://github.com/apache/shardingsphere/blob/master/docs/document/content/user-manual/shardingsphere-jdbc/configuration/java-api/readwrite-splitting.en.md))
- Encrypt Table Rule Configuration, Encrypt Column Rule Configuration and Encrypt Algorithm Configuration (in [Encryption](https://github.com/apache/shardingsphere/blob/master/docs/document/content/user-manual/shardingsphere-jdbc/configuration/java-api/encrypt.en.md))
- Governance [link](https://github.com/apache/shardingsphere/blob/master/docs/document/content/user-manual/shardingsphere-jdbc/configuration/java-api/governance.en.md)
3. The content of 4.x should not only contain `Readwrite-splitting`, more content can be copied from [here](https://shardingsphere.apache.org/document/legacy/4.x/document/en/manual/sharding-jdbc/configuration/config-java/#configuration-item-explanation)
4. As the same, more content of 3.x is [here](https://shardingsphere.apache.org/document/legacy/3.x/document/en/manual/sharding-jdbc/configuration/config-java/#configuration-reference)
5. Access to archived documents 2.x is not stable, so don't care about it this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-892799300
@tristaZero Should I add a `_index.en.md` inside java-api folder?
@RaigorJiang Do tell me from where I can find more information to write for 5.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-894639255
@RaigorJiang Done. Review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-894906025
> @RaigorJiang Done. Review it.
@Swastyy I think it's OK now, thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-892799300
@tristaZero Should I add a `_index.en.md` inside java-api folder?
@RaigorJiang Do tell me from where I can find more information to write for 5.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-893229043
@Swastyy Welcome to come back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang edited a comment on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
RaigorJiang edited a comment on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-893956875
@Swastyy
Thanks for your update, but I have some questions:
1. Why are there both `Readwrite-splitting` and `Replica Query` in `5.0.0-beta`, they actually have the same meaning, the current name is `Readwrite-splitting`. So please remove `Replica Query`.
2. The following configuration informations are missing in 5.0.0-beta:
- `Sharding Table Configuration`, `Sharding Automatic Table Configuration`, `Sharding Strategy Configuration` (in [Sharding](https://github.com/apache/shardingsphere/blob/master/docs/document/content/user-manual/shardingsphere-jdbc/configuration/java-api/sharding.en.md)
- `Root Configuration` (in [Readwrite-splitting](https://github.com/apache/shardingsphere/blob/master/docs/document/content/user-manual/shardingsphere-jdbc/configuration/java-api/readwrite-splitting.en.md))
- `Encrypt Table Rule Configuration`, `Encrypt Column Rule Configuration` and `Encrypt Algorithm Configuration` (in [Encryption](https://github.com/apache/shardingsphere/blob/master/docs/document/content/user-manual/shardingsphere-jdbc/configuration/java-api/encrypt.en.md))
- Governance [link](https://github.com/apache/shardingsphere/blob/master/docs/document/content/user-manual/shardingsphere-jdbc/configuration/java-api/governance.en.md)
3. The content of 4.x should not only contain `Readwrite-splitting`, more content can be copied from [here](https://shardingsphere.apache.org/document/legacy/4.x/document/en/manual/sharding-jdbc/configuration/config-java/#configuration-item-explanation)
4. As the same, more content of 3.x is [here](https://shardingsphere.apache.org/document/legacy/3.x/document/en/manual/sharding-jdbc/configuration/config-java/#configuration-reference)
5. Access to archived documents 2.x is not stable, so don't care about it this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-893115102
Hi @Swastyy
For information about version 5.0.0, please refer to the current version of the document. [Link](https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-jdbc/configuration/java-api/sharding/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-895953111
Hi @tristaZero , pl review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-893229043
@Swastyy Welcome to come back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang edited a comment on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
RaigorJiang edited a comment on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-894906025
> @RaigorJiang Done. Review it.
@Swastyy I think the content is OK now, thanks a lot. But the file path may be `others/api-change-history/shardingsphere-jdbc/java-api.en.md` ? Please check [it](https://github.com/apache/shardingsphere/tree/master/docs/document/content/others/api-change-history/shardingsphere-jdbc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-894642601
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11651](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f5e781c) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6596a4a0ffffff3c10442c83d36e59d430e10444?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6596a4a) will **decrease** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11651 +/- ##
============================================
- Coverage 63.79% 63.66% -0.13%
+ Complexity 1121 1120 -1
============================================
Files 2253 2264 +11
Lines 34391 34592 +201
Branches 6012 6028 +16
============================================
+ Hits 21939 22023 +84
- Misses 10681 10805 +124
+ Partials 1771 1764 -7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ce/core/yaml/pojo/YamlGovernanceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/11651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS95YW1sL3Bvam8vWWFtbEdvdmVybmFuY2VDb25maWd1cmF0aW9uLmphdmE=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...initializer/impl/AbstractBootstrapInitializer.java](https://codecov.io/gh/apache/shardingsphere/pull/11651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9pbml0aWFsaXplci9pbXBsL0Fic3RyYWN0Qm9vdHN0cmFwSW5pdGlhbGl6ZXIuamF2YQ==) | `5.88% <0.00%> (-39.58%)` | :arrow_down: |
| [...jdbc/core/datasource/ShardingSphereDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/11651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvZGF0YXNvdXJjZS9TaGFyZGluZ1NwaGVyZURhdGFTb3VyY2UuamF2YQ==) | `69.44% <0.00%> (-22.87%)` | :arrow_down: |
| [...api/GovernanceShardingSphereDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/11651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWdvdmVybmFuY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9nb3Zlcm5hbmNlL2FwaS9Hb3Zlcm5hbmNlU2hhcmRpbmdTcGhlcmVEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `35.71% <0.00%> (-21.43%)` | :arrow_down: |
| [.../apache/shardingsphere/shadow/rule/ShadowRule.java](https://codecov.io/gh/apache/shardingsphere/pull/11651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcnVsZS9TaGFkb3dSdWxlLmphdmE=) | `34.37% <0.00%> (-20.18%)` | :arrow_down: |
| [...arding/merge/dql/groupby/GroupByRowComparator.java](https://codecov.io/gh/apache/shardingsphere/pull/11651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvbWVyZ2UvZHFsL2dyb3VwYnkvR3JvdXBCeVJvd0NvbXBhcmF0b3IuamF2YQ==) | `73.33% <0.00%> (-13.34%)` | :arrow_down: |
| [...ml/swapper/ShadowRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/11651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cveWFtbC9zd2FwcGVyL1NoYWRvd1J1bGVDb25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `60.00% <0.00%> (-10.00%)` | :arrow_down: |
| [...itializer/impl/GovernanceBootstrapInitializer.java](https://codecov.io/gh/apache/shardingsphere/pull/11651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9pbml0aWFsaXplci9pbXBsL0dvdmVybmFuY2VCb290c3RyYXBJbml0aWFsaXplci5qYXZh) | `20.00% <0.00%> (-9.42%)` | :arrow_down: |
| [...initializer/impl/StandardBootstrapInitializer.java](https://codecov.io/gh/apache/shardingsphere/pull/11651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9pbml0aWFsaXplci9pbXBsL1N0YW5kYXJkQm9vdHN0cmFwSW5pdGlhbGl6ZXIuamF2YQ==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...a/binder/statement/dml/SelectStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/11651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `74.15% <0.00%> (-6.85%)` | :arrow_down: |
| ... and [75 more](https://codecov.io/gh/apache/shardingsphere/pull/11651/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6596a4a...f5e781c](https://codecov.io/gh/apache/shardingsphere/pull/11651?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-893115102
Hi @Swastyy
For information about version 5.0.0, please refer to the current version of the document. [Link](https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-jdbc/configuration/java-api/sharding/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on pull request #11651: Move change history in java api to others
Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11651:
URL: https://github.com/apache/shardingsphere/pull/11651#issuecomment-894945838
> > @RaigorJiang Done. Review it.
>
> @Swastyy I think the content is OK now, thanks a lot. But the file path may be `others/api-change-history/shardingsphere-jdbc/java-api.en.md` ? Please check [it](https://github.com/apache/shardingsphere/tree/master/docs/document/content/others/api-change-history/shardingsphere-jdbc).
Yeah, I have changed the file path. Thanks for pointing out @RaigorJiang .
@tristaZero Pl review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org