[GitHub] [flink] tillrohrmann commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy
URL: https://github.com/apache/flink/pull/8309#discussion_r287445669
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/InputDependencyConstraintChecker.java
 ##########
 @@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.scheduler.strategy;
+
+import org.apache.flink.api.common.InputDependencyConstraint;
+import org.apache.flink.runtime.jobgraph.IntermediateDataSet;
+import org.apache.flink.runtime.jobgraph.IntermediateDataSetID;
+import org.apache.flink.runtime.jobgraph.IntermediateResultPartitionID;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+import static org.apache.flink.api.common.InputDependencyConstraint.ALL;
+import static org.apache.flink.api.common.InputDependencyConstraint.ANY;
+import static org.apache.flink.runtime.io.network.partition.ResultPartitionType.BLOCKING;
+import static org.apache.flink.runtime.scheduler.strategy.SchedulingResultPartition.ResultPartitionState.DONE;
+import static org.apache.flink.runtime.scheduler.strategy.SchedulingResultPartition.ResultPartitionState.PRODUCING;
+
+/**
+ * A wrapper class for {@link InputDependencyConstraint} checker.
+ */
+public class InputDependencyConstraintChecker {
+	private final SchedulingIntermediateDataSetManager intermediateDataSetManager =
+		new SchedulingIntermediateDataSetManager();
+
+	public boolean check(final SchedulingExecutionVertex schedulingExecutionVertex) {
+		final InputDependencyConstraint inputConstraint = schedulingExecutionVertex.getInputDependencyConstraint();
+		if (schedulingExecutionVertex.getConsumedResultPartitions().isEmpty() || ALL.equals(inputConstraint)) {
+			return checkAll(schedulingExecutionVertex);
+		} else if (ANY.equals(inputConstraint)) {
+			return checkAny(schedulingExecutionVertex);
+		} else {
+			throw new IllegalArgumentException();
+		}
+	}
+
+	List<SchedulingResultPartition> markSchedulingResultPartitionFinished(SchedulingResultPartition srp) {
+		return intermediateDataSetManager.markSchedulingResultPartitionFinished(srp);
+	}
+
+	void resetSchedulingResultPartition(SchedulingResultPartition srp) {
+		intermediateDataSetManager.resetSchedulingResultPartition(srp);
+	}
+
+	void addSchedulingResultPartition(SchedulingResultPartition srp) {
+		intermediateDataSetManager.addSchedulingResultPartition(srp);
+	}
+
+	private boolean checkAll(final SchedulingExecutionVertex schedulingExecutionVertex) {
+		return schedulingExecutionVertex.getConsumedResultPartitions()
+			.stream()
+			.allMatch(this::partitionConsumable);
+	}
+
+	private boolean checkAny(final SchedulingExecutionVertex schedulingExecutionVertex) {
+		return schedulingExecutionVertex.getConsumedResultPartitions()
+			.stream()
+			.anyMatch(this::partitionConsumable);
+	}
+
+	private boolean partitionConsumable(SchedulingResultPartition partition) {
+		if (BLOCKING.equals(partition.getPartitionType())) {
+			return intermediateDataSetManager.allPartitionsFinished(partition);
+		} else {
+			SchedulingResultPartition.ResultPartitionState state = partition.getState();
+			return PRODUCING.equals(state) || DONE.equals(state);
+		}
+	}
+
+	private static class SchedulingIntermediateDataSetManager {
+
+		private final Map<IntermediateDataSetID, SchedulingIntermediateDataSet> intermediateDataSets = new HashMap<>();
+
+		List<SchedulingResultPartition> markSchedulingResultPartitionFinished(SchedulingResultPartition srp) {
+			SchedulingIntermediateDataSet intermediateDataSet = getSchedulingIntermediateDataSet(srp.getResultId(), false);
+			if (intermediateDataSet.markPartitionFinished(srp.getId())) {
+				return intermediateDataSet.getSchedulingResultPartition();
+			}
+			return Collections.emptyList();
+		}
+
+		void resetSchedulingResultPartition(SchedulingResultPartition srp) {
+			SchedulingIntermediateDataSet sid = getSchedulingIntermediateDataSet(srp.getResultId(), false);
+			sid.resetPartition(srp.getId());
+		}
+
+		void addSchedulingResultPartition(SchedulingResultPartition srp) {
+			SchedulingIntermediateDataSet sid = getSchedulingIntermediateDataSet(srp.getResultId(), true);
+			sid.addSchedulingResultPartition(srp);
+		}
+
+		boolean allPartitionsFinished(SchedulingResultPartition srp) {
+			SchedulingIntermediateDataSet sid = getSchedulingIntermediateDataSet(srp.getResultId(), false);
 
 Review comment:
   Instead of using a boolean one could introduce two methods for that
   
   `false` --> `getSchedulingIntermediateDataSet`
   `true` --> `getSchedulingIntermediateDataSetOrCreate`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services