You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/04/18 22:55:01 UTC

[jira] [Commented] (GEODE-5043) Protobuf server and client are sending multiple packets for a single request

    [ https://issues.apache.org/jira/browse/GEODE-5043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443303#comment-16443303 ] 

ASF subversion and git services commented on GEODE-5043:
--------------------------------------------------------

Commit c303d01e408bc903f8ff5ac54b551618a4c5e782 in geode's branch refs/heads/develop from [~geodeintegration]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c303d01 ]

GEODE-5043: Buffering protobuf output to avoid multiple packet sends (#1768)

GEODE-5043: Buffering protobuf output to avoid multiple packet sends

Based on the stats all protobuf requests and responses were being sent
as two packets. Using a BufferedOutputStream to make sure we only send 1
packet


> Protobuf server and client are sending multiple packets for a single request
> ----------------------------------------------------------------------------
>
>                 Key: GEODE-5043
>                 URL: https://issues.apache.org/jira/browse/GEODE-5043
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> While doing some performance testing, we discovered that the protobuf client and protobuf server are actually sending multiple packets per request and response based on the the LinuxSystemStats.xmitPackets. The messages are small enough they should fit in a single packet.
>  
> Looking at the code, it looks like in both the client and the server we are writing directly to socket.getOutputStream(). As soon as data is written to that outputstream it could be sent to the the remote side. Wrapping that in the BufferedOutputStream eleminates the duplicate packets and improves the performance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)