[GitHub] [flink] sopan98 opened a new pull request, #21183: [FLINK-29789][tests] Fix flaky test in CheckpointCoordinatorTest

[GitBox <gi...@apache.org>]

sopan98 opened a new pull request, #21183:
URL: https://github.com/apache/flink/pull/21183

   This PR aims to solve the issue presented here: https://issues.apache.org/jira/browse/FLINK-29789
   
   ## What is the purpose of the change
   The fix is to change the HashMap of PendingCheckpoint in CheckpointCoordinator to LinkedHashMap to make the tests more stable (less flaky).
   
   ## Brief change log
   - Changing the map implementation of PendingCheckpoint in CheckpointCoordinator
   
   ## Verifying this change
   Existing tests already cover this change, and it can pass them successfully.
   The tests are: 
   1. org.apache.flink.runtime.checkpoint.CheckpointCoordinatorTest.testTriggerAndDeclineCheckpointComplex
   
   ## Does this pull request potentially affect one of the following parts:
   * Dependencies (does it add or upgrade a dependency): No
   * The public API, i.e., is any changed class annotated with `@Public(Evolving)`: No
   * The serializers: No
   * The runtime per-record code paths (performance sensitive): No
   * Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos,, ZooKeeper: No
   * The S3 file system connector: No
   
   ## Documentation
   Does this pull request introduce a new feature? No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21183: [FLINK-29789][tests] Fix flaky test in CheckpointCoordinatorTest

[GitBox <gi...@apache.org>]

flinkbot commented on PR #21183:
URL: https://github.com/apache/flink/pull/21183#issuecomment-1294459420

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6cb844d32692779b408f5f216899183ff2f849b7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6cb844d32692779b408f5f216899183ff2f849b7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6cb844d32692779b408f5f216899183ff2f849b7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org