You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2016/01/27 18:02:31 UTC

Re: Review Request 42841: WIP: Introducing appc image fetcher.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42841/
-----------------------------------------------------------

(Updated Jan. 27, 2016, 5:02 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

rebased after cache change.


Repository: mesos


Description
-------

WIP: Introducing appc image fetcher.


Diffs (updated)
-----

  src/CMakeLists.txt 47d0a7c0fe73b9297cd7dde6086b5e6e9e1f9e4e 
  src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
  src/slave/containerizer/mesos/provisioner/appc/image_fetcher.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/image_fetcher.cpp PRE-CREATION 
  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 

Diff: https://reviews.apache.org/r/42841/diff/


Testing
-------

make check; local image server


Thanks,

Jojy Varghese


Re: Review Request 42841: WIP: Introducing appc image fetcher.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42841/#review116599
-----------------------------------------------------------



Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos ReviewBot


On Jan. 27, 2016, 5:02 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42841/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 5:02 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP: Introducing appc image fetcher.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 47d0a7c0fe73b9297cd7dde6086b5e6e9e1f9e4e 
>   src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
>   src/slave/containerizer/mesos/provisioner/appc/image_fetcher.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/image_fetcher.cpp PRE-CREATION 
>   src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
>   src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
> 
> Diff: https://reviews.apache.org/r/42841/diff/
> 
> 
> Testing
> -------
> 
> make check; local image server
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Re: Review Request 42841: WIP: Introducing appc image fetcher.

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42841/
-----------------------------------------------------------

(Updated Feb. 6, 2016, 1:36 a.m.)


Review request for Jie Yu.


Changes
-------

rebased.


Repository: mesos


Description
-------

WIP: Introducing appc image fetcher.


Diffs (updated)
-----

  src/CMakeLists.txt 4a2954498efa48a4eb43f82827ff1d6f5f65d389 
  src/Makefile.am 22f51319a1c06da02cac5822d42315e3027cf500 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp PRE-CREATION 
  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 

Diff: https://reviews.apache.org/r/42841/diff/


Testing
-------

make check; local image server


Thanks,

Jojy Varghese


Re: Review Request 42841: WIP: Introducing appc image fetcher.

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42841/
-----------------------------------------------------------

(Updated Feb. 4, 2016, 2:55 a.m.)


Review request for Jie Yu.


Changes
-------

rebased.


Repository: mesos


Description
-------

WIP: Introducing appc image fetcher.


Diffs (updated)
-----

  src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp PRE-CREATION 
  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 

Diff: https://reviews.apache.org/r/42841/diff/


Testing
-------

make check; local image server


Thanks,

Jojy Varghese


Re: Review Request 42841: WIP: Introducing appc image fetcher.

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42841/
-----------------------------------------------------------

(Updated Feb. 3, 2016, 1:31 a.m.)


Review request for Jie Yu.


Repository: mesos


Description
-------

WIP: Introducing appc image fetcher.


Diffs (updated)
-----

  src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp PRE-CREATION 
  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 

Diff: https://reviews.apache.org/r/42841/diff/


Testing
-------

make check; local image server


Thanks,

Jojy Varghese


Re: Review Request 42841: WIP: Introducing appc image fetcher.

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42841/
-----------------------------------------------------------

(Updated Feb. 1, 2016, 7:56 p.m.)


Review request for Jie Yu.


Repository: mesos


Description
-------

WIP: Introducing appc image fetcher.


Diffs (updated)
-----

  src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/slave/containerizer/mesos/provisioner/appc/image_fetcher.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/image_fetcher.cpp PRE-CREATION 
  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 

Diff: https://reviews.apache.org/r/42841/diff/


Testing
-------

make check; local image server


Thanks,

Jojy Varghese


Re: Review Request 42841: WIP: Introducing appc image fetcher.

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42841/
-----------------------------------------------------------

(Updated Jan. 30, 2016, 2:07 a.m.)


Review request for Jie Yu.


Repository: mesos


Description
-------

WIP: Introducing appc image fetcher.


Diffs (updated)
-----

  src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/slave/containerizer/mesos/provisioner/appc/image_fetcher.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/image_fetcher.cpp PRE-CREATION 
  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 

Diff: https://reviews.apache.org/r/42841/diff/


Testing
-------

make check; local image server


Thanks,

Jojy Varghese


Re: Review Request 42841: WIP: Introducing appc image fetcher.

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42841/
-----------------------------------------------------------

(Updated Jan. 29, 2016, 12:58 a.m.)


Review request for Jie Yu.


Repository: mesos


Description
-------

WIP: Introducing appc image fetcher.


Diffs (updated)
-----

  src/CMakeLists.txt 93caf000f39bbb71a17d9876689afb50cf637e44 
  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/slave/containerizer/mesos/provisioner/appc/image_fetcher.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/image_fetcher.cpp PRE-CREATION 
  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 

Diff: https://reviews.apache.org/r/42841/diff/


Testing
-------

make check; local image server


Thanks,

Jojy Varghese


Re: Review Request 42841: WIP: Introducing appc image fetcher.

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42841/
-----------------------------------------------------------

(Updated Jan. 28, 2016, 7:10 p.m.)


Review request for Jie Yu.


Changes
-------

rebased.


Repository: mesos


Description
-------

WIP: Introducing appc image fetcher.


Diffs (updated)
-----

  src/CMakeLists.txt 93caf000f39bbb71a17d9876689afb50cf637e44 
  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/slave/containerizer/mesos/provisioner/appc/image_fetcher.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/image_fetcher.cpp PRE-CREATION 
  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 

Diff: https://reviews.apache.org/r/42841/diff/


Testing
-------

make check; local image server


Thanks,

Jojy Varghese


Re: Review Request 42841: WIP: Introducing appc image fetcher.

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42841/
-----------------------------------------------------------

(Updated Jan. 27, 2016, 8:26 p.m.)


Review request for Jie Yu.


Changes
-------

rebased


Repository: mesos


Description
-------

WIP: Introducing appc image fetcher.


Diffs (updated)
-----

  src/CMakeLists.txt 47d0a7c0fe73b9297cd7dde6086b5e6e9e1f9e4e 
  src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
  src/slave/containerizer/mesos/provisioner/appc/image_fetcher.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/image_fetcher.cpp PRE-CREATION 
  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 

Diff: https://reviews.apache.org/r/42841/diff/


Testing
-------

make check; local image server


Thanks,

Jojy Varghese