You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/10/27 14:35:36 UTC

Review Request 27226: HDP2.2. Zookeeper package creates "current/zookeeper-client" link

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27226/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.


Bugs: AMBARI-7982
    https://issues.apache.org/jira/browse/AMBARI-7982


Repository: ambari


Description
-------

Package zookeeper_2_2_0_0_1108.noarch creates a link
[root@c6406 ~]# ls -la /usr/hdp/current/
total 8
drwxr-xr-x 2 root root 4096 Oct 27 10:36 .
drwxr-xr-x 4 root root 4096 Oct 27 10:36 ..
lrwxrwxrwx 1 root root 31 Oct 27 10:36 zookeeper-client -> /usr/hdp/2.2.0.0-1108/zookeeper
It breaks any Ambari deployments, because Ambari checks if /usr/hdp/current/ already exists before running hdp-select
Solution:
run hdp-select after every install command, but use -r option. -r creates a symbolic link in /usr/hdp/current/ folder only if it's absent


Diffs
-----

  ambari-agent/src/test/python/resource_management/TestPackageResource.py a28eb2d 
  ambari-common/src/main/python/resource_management/core/providers/package/apt.py 19786dd 
  ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py 7b729f8 
  ambari-common/src/main/python/resource_management/core/providers/package/zypper.py 6577c47 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 081906f 

Diff: https://reviews.apache.org/r/27226/diff/


Testing
-------

manually tested on Ubuntu and CentOS6

+

----------------------------------------------------------------------
Ran 308 tests in 5.747s

OK

Process finished with exit code 0


Thanks,

Dmytro Sen


Re: Review Request 27226: HDP2.2. Zookeeper package creates "current/zookeeper-client" link

Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27226/#review58616
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On Oct. 27, 2014, 1:35 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27226/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 1:35 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-7982
>     https://issues.apache.org/jira/browse/AMBARI-7982
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Package zookeeper_2_2_0_0_1108.noarch creates a link
> [root@c6406 ~]# ls -la /usr/hdp/current/
> total 8
> drwxr-xr-x 2 root root 4096 Oct 27 10:36 .
> drwxr-xr-x 4 root root 4096 Oct 27 10:36 ..
> lrwxrwxrwx 1 root root 31 Oct 27 10:36 zookeeper-client -> /usr/hdp/2.2.0.0-1108/zookeeper
> It breaks any Ambari deployments, because Ambari checks if /usr/hdp/current/ already exists before running hdp-select
> Solution:
> run hdp-select after every install command, but use -r option. -r creates a symbolic link in /usr/hdp/current/ folder only if it's absent
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py a28eb2d 
>   ambari-common/src/main/python/resource_management/core/providers/package/apt.py 19786dd 
>   ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py 7b729f8 
>   ambari-common/src/main/python/resource_management/core/providers/package/zypper.py 6577c47 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 081906f 
> 
> Diff: https://reviews.apache.org/r/27226/diff/
> 
> 
> Testing
> -------
> 
> manually tested on Ubuntu and CentOS6
> 
> +
> 
> ----------------------------------------------------------------------
> Ran 308 tests in 5.747s
> 
> OK
> 
> Process finished with exit code 0
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 27226: HDP2.2. Zookeeper package creates "current/zookeeper-client" link

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27226/#review58607
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On Oct. 27, 2014, 1:35 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27226/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 1:35 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-7982
>     https://issues.apache.org/jira/browse/AMBARI-7982
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Package zookeeper_2_2_0_0_1108.noarch creates a link
> [root@c6406 ~]# ls -la /usr/hdp/current/
> total 8
> drwxr-xr-x 2 root root 4096 Oct 27 10:36 .
> drwxr-xr-x 4 root root 4096 Oct 27 10:36 ..
> lrwxrwxrwx 1 root root 31 Oct 27 10:36 zookeeper-client -> /usr/hdp/2.2.0.0-1108/zookeeper
> It breaks any Ambari deployments, because Ambari checks if /usr/hdp/current/ already exists before running hdp-select
> Solution:
> run hdp-select after every install command, but use -r option. -r creates a symbolic link in /usr/hdp/current/ folder only if it's absent
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py a28eb2d 
>   ambari-common/src/main/python/resource_management/core/providers/package/apt.py 19786dd 
>   ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py 7b729f8 
>   ambari-common/src/main/python/resource_management/core/providers/package/zypper.py 6577c47 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 081906f 
> 
> Diff: https://reviews.apache.org/r/27226/diff/
> 
> 
> Testing
> -------
> 
> manually tested on Ubuntu and CentOS6
> 
> +
> 
> ----------------------------------------------------------------------
> Ran 308 tests in 5.747s
> 
> OK
> 
> Process finished with exit code 0
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 27226: HDP2.2. Zookeeper package creates "current/zookeeper-client" link

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27226/#review58609
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Oct. 27, 2014, 1:35 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27226/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 1:35 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-7982
>     https://issues.apache.org/jira/browse/AMBARI-7982
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Package zookeeper_2_2_0_0_1108.noarch creates a link
> [root@c6406 ~]# ls -la /usr/hdp/current/
> total 8
> drwxr-xr-x 2 root root 4096 Oct 27 10:36 .
> drwxr-xr-x 4 root root 4096 Oct 27 10:36 ..
> lrwxrwxrwx 1 root root 31 Oct 27 10:36 zookeeper-client -> /usr/hdp/2.2.0.0-1108/zookeeper
> It breaks any Ambari deployments, because Ambari checks if /usr/hdp/current/ already exists before running hdp-select
> Solution:
> run hdp-select after every install command, but use -r option. -r creates a symbolic link in /usr/hdp/current/ folder only if it's absent
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py a28eb2d 
>   ambari-common/src/main/python/resource_management/core/providers/package/apt.py 19786dd 
>   ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py 7b729f8 
>   ambari-common/src/main/python/resource_management/core/providers/package/zypper.py 6577c47 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 081906f 
> 
> Diff: https://reviews.apache.org/r/27226/diff/
> 
> 
> Testing
> -------
> 
> manually tested on Ubuntu and CentOS6
> 
> +
> 
> ----------------------------------------------------------------------
> Ran 308 tests in 5.747s
> 
> OK
> 
> Process finished with exit code 0
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>