You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Ivan <xh...@gmail.com> on 2010/10/20 04:59:59 UTC
Pull the latest Tomcat codes to our own repository
Hi,
Seems many changes are done to Tomcat trunk since we pulled the codes
last time. I am thinking to pull the codes. Before that, I would like to
know whether anyone is working on our own Tomcat repository.
Thanks.
--
Ivan
Re: Pull the latest Tomcat codes to our own repository
Posted by Ivan <xh...@gmail.com>.
I have pulled the latest Tomcat trunk codes to our own repository. Some
extra changes are included :
a. Comment out the reference of BackupManager in the HTMLManagerServlet due
to the recursive dependency. I have posted an email to Tomcat community,
let's wait to see ...
b. Replace the reference of Globles with static string in the japser module,
as we do not wish it depends on Catalia.
c. Include the extra fix for AsyncLisener.
I will deploy the snapshots to the repository later if everything works
well.
2010/10/20 Ivan <xh...@gmail.com>
> Yes, I know it is better to solve this from its root, but from the
> experience in the past ...
> I will try.
>
> 2010/10/20 Kevan Miller <ke...@gmail.com>
>
>
>> On Oct 20, 2010, at 2:25 AM, Ivan wrote:
>>
>> > Just find an annoying change in the latest Tomcat codes, a class
>> HTMLManagerServlet in the catalina package refers to a class in the
>> catalina-ha.
>> > I plan to move this class to the catalina-ha package, seems that this
>> class is not refered by any other classes in the Tomcat code base. or anyone
>> has better ideas ?
>>
>> I expect that the following is your intention, but I think it's worth
>> stating -- this should be taken up with the Tomcat community. Our goal
>> should be to not have any long-term changes to Tomcat. We should be working
>> with the Tomcat community to understand our problems and have our updates
>> applied to Tomcat, not in our externals release.
>>
>> In this instance, I don't understand why HTMLManagerServlet needs to be
>> aware of the specific Manager sub-class, at all. Seems like the Manager
>> interface could have provided an appropriate method for retrieving the
>> desired information.
>>
>> --kevan
>
>
>
>
> --
> Ivan
>
--
Ivan
Re: Pull the latest Tomcat codes to our own repository
Posted by Ivan <xh...@gmail.com>.
Yes, I know it is better to solve this from its root, but from the
experience in the past ...
I will try.
2010/10/20 Kevan Miller <ke...@gmail.com>
>
> On Oct 20, 2010, at 2:25 AM, Ivan wrote:
>
> > Just find an annoying change in the latest Tomcat codes, a class
> HTMLManagerServlet in the catalina package refers to a class in the
> catalina-ha.
> > I plan to move this class to the catalina-ha package, seems that this
> class is not refered by any other classes in the Tomcat code base. or anyone
> has better ideas ?
>
> I expect that the following is your intention, but I think it's worth
> stating -- this should be taken up with the Tomcat community. Our goal
> should be to not have any long-term changes to Tomcat. We should be working
> with the Tomcat community to understand our problems and have our updates
> applied to Tomcat, not in our externals release.
>
> In this instance, I don't understand why HTMLManagerServlet needs to be
> aware of the specific Manager sub-class, at all. Seems like the Manager
> interface could have provided an appropriate method for retrieving the
> desired information.
>
> --kevan
--
Ivan
Re: Pull the latest Tomcat codes to our own repository
Posted by Kevan Miller <ke...@gmail.com>.
On Oct 20, 2010, at 2:25 AM, Ivan wrote:
> Just find an annoying change in the latest Tomcat codes, a class HTMLManagerServlet in the catalina package refers to a class in the catalina-ha.
> I plan to move this class to the catalina-ha package, seems that this class is not refered by any other classes in the Tomcat code base. or anyone has better ideas ?
I expect that the following is your intention, but I think it's worth stating -- this should be taken up with the Tomcat community. Our goal should be to not have any long-term changes to Tomcat. We should be working with the Tomcat community to understand our problems and have our updates applied to Tomcat, not in our externals release.
In this instance, I don't understand why HTMLManagerServlet needs to be aware of the specific Manager sub-class, at all. Seems like the Manager interface could have provided an appropriate method for retrieving the desired information.
--kevan
Re: Pull the latest Tomcat codes to our own repository
Posted by Ivan <xh...@gmail.com>.
Or update the codes to use reflection invocation ?
2010/10/20 Ivan <xh...@gmail.com>
> Just find an annoying change in the latest Tomcat codes, a class
> HTMLManagerServlet in the catalina package refers to a class in the
> catalina-ha.
> I plan to move this class to the catalina-ha package, seems that this class
> is not refered by any other classes in the Tomcat code base. or anyone has
> better ideas ?
>
> 2010/10/20 David Jencks <da...@yahoo.com>
>
> Tomcat accepted all but one of my bug fixes (the one they didn't accept is
>> a different interpretation of a spec contradiction). I can re-patch a new
>> copy pending finding out which interpretation we should accept. I'm not
>> working on any changes currently.... please go ahead.
>>
>> thanks
>> david jencks
>>
>>
>>
>> On Oct 19, 2010, at 7:59 PM, Ivan wrote:
>>
>> > Hi,
>> > Seems many changes are done to Tomcat trunk since we pulled the codes
>> last time. I am thinking to pull the codes. Before that, I would like to
>> know whether anyone is working on our own Tomcat repository.
>> > Thanks.
>> >
>> > --
>> > Ivan
>>
>>
>
>
> --
> Ivan
>
--
Ivan
Re: Pull the latest Tomcat codes to our own repository
Posted by Ivan <xh...@gmail.com>.
Just find an annoying change in the latest Tomcat codes, a class
HTMLManagerServlet in the catalina package refers to a class in the
catalina-ha.
I plan to move this class to the catalina-ha package, seems that this class
is not refered by any other classes in the Tomcat code base. or anyone has
better ideas ?
2010/10/20 David Jencks <da...@yahoo.com>
> Tomcat accepted all but one of my bug fixes (the one they didn't accept is
> a different interpretation of a spec contradiction). I can re-patch a new
> copy pending finding out which interpretation we should accept. I'm not
> working on any changes currently.... please go ahead.
>
> thanks
> david jencks
>
>
>
> On Oct 19, 2010, at 7:59 PM, Ivan wrote:
>
> > Hi,
> > Seems many changes are done to Tomcat trunk since we pulled the codes
> last time. I am thinking to pull the codes. Before that, I would like to
> know whether anyone is working on our own Tomcat repository.
> > Thanks.
> >
> > --
> > Ivan
>
>
--
Ivan
Re: Pull the latest Tomcat codes to our own repository
Posted by David Jencks <da...@yahoo.com>.
Tomcat accepted all but one of my bug fixes (the one they didn't accept is a different interpretation of a spec contradiction). I can re-patch a new copy pending finding out which interpretation we should accept. I'm not working on any changes currently.... please go ahead.
thanks
david jencks
On Oct 19, 2010, at 7:59 PM, Ivan wrote:
> Hi,
> Seems many changes are done to Tomcat trunk since we pulled the codes last time. I am thinking to pull the codes. Before that, I would like to know whether anyone is working on our own Tomcat repository.
> Thanks.
>
> --
> Ivan