You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/03/26 19:13:41 UTC
[GitHub] [netbeans] vieiro opened a new pull request #2832: [NETBEANS-4619] Adding some missing licenses
vieiro opened a new pull request #2832:
URL: https://github.com/apache/netbeans/pull/2832
This PR adds some missing licenses to different files and updates `nbbuild/rat-exclusions.txt` excluding cnd templates and test files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #2832: [NETBEANS-4619] Adding some missing licenses
Posted by GitBox <gi...@apache.org>.
vieiro commented on pull request #2832:
URL: https://github.com/apache/netbeans/pull/2832#issuecomment-808455713
This also fixes a bug in one of the native files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2832: [NETBEANS-4619] [cnd] Adding some missing licenses
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2832:
URL: https://github.com/apache/netbeans/pull/2832#discussion_r605155454
##########
File path: nbbuild/rat-exclusions.txt
##########
@@ -146,6 +150,104 @@ ide/properties/src/org/netbeans/modules/properties/sample.properties.template
java/selenium2.java/src/org/netbeans/modules/selenium2/java/SeleneseIT.java.template
java/testng.ui/src/org/netbeans/modules/testng/ui/resources/*.template
websvccommon/websvc.saas.api/src/org/netbeans/modules/websvc/saas/oauth/*.template
+# cnd template files
Review comment:
Is it really not possible to include the ALv2 license in each of these files? We had other cases where the templates are processed and the template language allowed to have the licenses header and the licenses would not show up in the generated file (freemarker for example allows to place comments in files).
In anycase, I'd like to prefer to use the licenseinfo.xml facitily to document, that the files are actually ALv2 and not just plain ignored (the build system reads licenseinfo.xml and generates a report from that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro closed pull request #2832: [NETBEANS-4619] [cnd] Adding some missing licenses
Posted by GitBox <gi...@apache.org>.
vieiro closed pull request #2832:
URL: https://github.com/apache/netbeans/pull/2832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #2832: [NETBEANS-4619] [cnd] Adding some missing licenses
Posted by GitBox <gi...@apache.org>.
vieiro commented on pull request #2832:
URL: https://github.com/apache/netbeans/pull/2832#issuecomment-811423942
Thanks for the review, @matthiasblaesing !
For CND we'll need many PRs, I'm afraid, and I'd like to **very** strict with all licensing details we'll be facing.
Let me try to investigate if those Makefile templates are/could be processed with Freemaker, let's see what should go into licensinfo.xml and let's also separate the two commits in different PRs.
So let's close this PR and do different PRs for them. I think we need this level of detail in CND. Apologies for the noise and thanks again for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists