You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "imzs (via GitHub)" <gi...@apache.org> on 2024/11/22 06:26:57 UTC
[PR] [ISSUE #8974] Support recalling of delay message [rocketmq]
imzs opened a new pull request, #8975:
URL: https://github.com/apache/rocketmq/pull/8975
[ISSUE #8974] Support recalling of delay message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8974] Support recalling of delay message [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8975:
URL: https://github.com/apache/rocketmq/pull/8975#issuecomment-2505518766
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8975?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `65.77540%` with `128 lines` in your changes missing coverage. Please review.
> Project coverage is 48.06%. Comparing base [(`715dd5a`)](https://app.codecov.io/gh/apache/rocketmq/commit/715dd5a885ae89ebc05aea33971029d7306c80ae?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b50755f`)](https://app.codecov.io/gh/apache/rocketmq/commit/b50755f312a42c3c33b8cbe27d345099f4d7268f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 7 commits behind head on develop.
| [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/8975?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ient/trace/hook/DefaultRecallMessageTraceHook.java](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Ftrace%2Fhook%2FDefaultRecallMessageTraceHook.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvaG9vay9EZWZhdWx0UmVjYWxsTWVzc2FnZVRyYWNlSG9vay5qYXZh) | 12.90% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/rocketmq/client/trace/TraceDataEncoder.java](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Ftrace%2FTraceDataEncoder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvVHJhY2VEYXRhRW5jb2Rlci5qYXZh) | 0.00% | [22 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ng/protocol/header/RecallMessageRequestHeader.java](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&filepath=remoting%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fremoting%2Fprotocol%2Fheader%2FRecallMessageRequestHeader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL2hlYWRlci9SZWNhbGxNZXNzYWdlUmVxdWVzdEhlYWRlci5qYXZh) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...cketmq/proxy/grpc/v2/GrpcMessagingApplication.java](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fgrpc%2Fv2%2FGrpcMessagingApplication.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvdjIvR3JwY01lc3NhZ2luZ0FwcGxpY2F0aW9uLmphdmE=) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ketmq/broker/processor/RecallMessageProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Fprocessor%2FRecallMessageProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1JlY2FsbE1lc3NhZ2VQcm9jZXNzb3IuamF2YQ==) | 89.36% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/rocketmq/common/BrokerConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fcommon%2FBrokerConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vQnJva2VyQ29uZmlnLmphdmE=) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...g/protocol/header/RecallMessageResponseHeader.java](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&filepath=remoting%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fremoting%2Fprotocol%2Fheader%2FRecallMessageResponseHeader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL2hlYWRlci9SZWNhbGxNZXNzYWdlUmVzcG9uc2VIZWFkZXIuamF2YQ==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ing/protocol/header/SendMessageResponseHeader.java](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&filepath=remoting%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fremoting%2Fprotocol%2Fheader%2FSendMessageResponseHeader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL2hlYWRlci9TZW5kTWVzc2FnZVJlc3BvbnNlSGVhZGVyLmphdmE=) | 28.57% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2FMQClientAPIImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | 81.25% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...tmq/proxy/service/message/LocalMessageService.java](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fservice%2Fmessage%2FLocalMessageService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2UvbWVzc2FnZS9Mb2NhbE1lc3NhZ2VTZXJ2aWNlLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [15 more](https://app.codecov.io/gh/apache/rocketmq/pull/8975?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #8975 +/- ##
=============================================
+ Coverage 47.66% 48.06% +0.39%
- Complexity 11766 12125 +359
=============================================
Files 1304 1311 +7
Lines 91174 93606 +2432
Branches 11711 12271 +560
=============================================
+ Hits 43456 44988 +1532
- Misses 42346 43167 +821
- Partials 5372 5451 +79
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8975?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8974] Support recalling of delay message [rocketmq]
Posted by "qianye1001 (via GitHub)" <gi...@apache.org>.
qianye1001 commented on PR #8975:
URL: https://github.com/apache/rocketmq/pull/8975#issuecomment-2493303113
Returning an additional handle in all send Response operations introduces overhead. If this feature is not required, there should be an option to disable it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8974] Support recalling of delay message [rocketmq]
Posted by "imzs (via GitHub)" <gi...@apache.org>.
imzs commented on PR #8975:
URL: https://github.com/apache/rocketmq/pull/8975#issuecomment-2505139116
> It seems that the newly added integration test are failing. 
The tests passed locally, it maybe timeout issue; I'll try to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8974] Support recalling of delay message [rocketmq]
Posted by "imzs (via GitHub)" <gi...@apache.org>.
imzs commented on PR #8975:
URL: https://github.com/apache/rocketmq/pull/8975#issuecomment-2493348702
> Returning an additional handle in all send Response operations introduces overhead. If this feature is not required, there should be an option to disable it.
This field is somewhat similar to `transactionId`. As previously mentioned, the API defines a common semantic. In cases where unsupported message types are encountered, it returns null values, which also implies that the current message does not support recall operation, this may be considered as a switch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8974] Support recalling of delay message [rocketmq]
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on PR #8975:
URL: https://github.com/apache/rocketmq/pull/8975#issuecomment-2499990167
It seems that the newly added integration test are failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8974] Support recalling of delay message [rocketmq]
Posted by "lollipopjin (via GitHub)" <gi...@apache.org>.
lollipopjin merged PR #8975:
URL: https://github.com/apache/rocketmq/pull/8975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org